Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple link support #107

Closed
emteknetnz opened this issue Oct 24, 2023 · 1 comment
Closed

Multiple link support #107

emteknetnz opened this issue Oct 24, 2023 · 1 comment

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Oct 24, 2023

Story

As a CMS User I want to be able to add multiple links to a link field so that I am not limited to adding only a single link

Acceptance criteria

  • Ability to add multiple links to a link field
  • Ability to delete links from a link field
  • Multi link field works in both Elemental inline form and regular pages forms.
  • Design has been validated with UX team
  • Documentation is updated to mention how to manage links of list

Notes

  • There is an implementation in an old PR that may be useful - Add multi link support #45
  • We never validated how the LinkField should look when rendering many links
  • The POC splits the Single Link and Many Link fields into two different form fields. We're not tied to that approach, although it probably makes sense.
  • We have some pre-existing problems with fields that need to read their relation on their parent data object. This has cause us problems with the Upload field in Elemental in the past.

Exclude

  • Ability to sort multiple links within a link field (will split as a separate card)

Rough design - doesn't have to be exact

image

PRs

@emteknetnz
Copy link
Member Author

Linked PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants