Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module standardisation #95

Closed
4 of 6 tasks
maxime-rainville opened this issue Sep 28, 2023 · 4 comments
Closed
4 of 6 tasks

Module standardisation #95

maxime-rainville opened this issue Sep 28, 2023 · 4 comments

Comments

@maxime-rainville
Copy link

maxime-rainville commented Sep 28, 2023

Story

As a dev team, we want the module to be in a good state for development.

Acceptance criteria

  • Linkfield is added to Rihno
  • A next major branch is created and follows our conventions
  • Module is set up to run our standard CI
  • Module is tracked in transifex
  • Module is added to the sink
  • Module is constrained to CMS 5

PRs

@emteknetnz
Copy link
Member

emteknetnz commented Sep 28, 2023

This card is mostly done

Linkfield is added to Rhino

I've updated rhino, linkfield is now showing

A next major branch is created and follows our conventions

I've created a new 4 branch from the old 3 branch and added the standard branch protection rules. We'll hold off making a 4.0 branch until we're ready to tag stable so so that we don't need to worry about merge-up overhead.

I've changed the default branch to 4 so that new PR's target that so we don't accidentally target the wrong branch. Note the old major 3 never got out of beta so I don't think it's incorrect to just change the default branch now.

Module is set up to run our standard CI

I've got a PR open for this #93

Module is tracked in transifex

I've created a new project in transifex silverstripe-linkfield and copied settings for the existing silverstripe-versioned - though we'll need to actually push some translation up before it's fully ready. There are no existing translations in linkfield though we'll inevitably add some

Module is added to the sink

PR silverstripe/recipe-kitchen-sink#48

Module is constrained to CMS 5

The 4 branch has a composer requirement for silverstripe/cms ^5

@GuySartorelli
Copy link
Member

GuySartorelli commented Sep 28, 2023

Can we please not action cards like this without refining them? This module should not be in rhino or kitchen sink imo.

@maxime-rainville
Copy link
Author

Some of these ACs have already been actioned. There's some point to sort out about how and we iterate and promote linkfield once we actively start working on it.

@emteknetnz emteknetnz changed the title Set up major branch for dev Module standardisation Jan 7, 2024
@GuySartorelli
Copy link
Member

Outstanding PRs and acceptance criteria have been moved to #78
Closing as duplicate

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants