-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Remember this device' feature #384
Comments
So this is different from the existing "remember me" feature as they still want a single factor of authentication? |
Yes, but to be honest I had forgot to consider the existing 'Keep me signed in' feature! I'm going to close this issue in light of that. |
Perhaps this would help? #385 |
Reopening this. We're stating to see a real demand for this, as it's perceived that the the 'Keep me signed in' feature is not always secure enough as it also removes the need to enter the email and password. I feel like #385 is still relevant to add given it outlines the security considerations that need to be made when using the feature. I've added draft ACs to the description. |
There's of course more potential enhancements down this path like 'managing' trusted devices (as Google offers) via the user's Profile page. |
Another AC to consider here:
|
There's significant overlap with the ability to manage and invalidate sessions across devices (through a login session database record): silverstripe/silverstripe-framework#8694. As a recap, currently the CMS allows "remember me" as a user opt-in on login. If selected, it generates a Remember Login Hash, associates it to the user, and writes it into the user cookie. If the session expires, but the value exists in the cookie, it automatically starts a new session without asking for authentication or MFA codes. This works from multiple devices already. When any of the devices logs out, the default behaviour is to invalidate all Remember Login Hash records for the user (since there's no centralised management UI). Might be useful to put down some definitions so we're all talking about the same things:
I think it's going to introduce a lot of unnecessary complexity if we decide to treat Device as a different concept from Login Session. /cc @silverstripe/ux-contributors @silverstripeux |
Awesome thanks @chillu |
This feature might already exist in a better way than being part of this 'core' module. Have not used, have not tested. Just saw it in the dependency graph. |
Overview
There are a significant amount of site owners that will only access their site admin over an already mostly-secure network, i.e within the workplace office; over the workplace network/VPN; through an IP whitelist, etc.
The friction of MFA could be reduced for these users by introducing a 'remember this device for x days' feature, storing a cookie in the device browser and not require the user to authenticate with MFA until it expires.
This work is currently not planned but feedback on the implementation (or contributions) are of course welcome.
ACs (draft)
TBC:
The text was updated successfully, but these errors were encountered: