Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to resource for PHP8.1 #141

Open
1 of 2 tasks
GuySartorelli opened this issue Sep 15, 2022 · 0 comments
Open
1 of 2 tasks

Update references to resource for PHP8.1 #141

GuySartorelli opened this issue Sep 15, 2022 · 0 comments

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Sep 15, 2022

PHP8.1 uses concrete classes where resources used to be used. e.g. PgSql\Result replaces the result resource, and PgSql\Connection replaces the connection resource.

Acceptance criteria

  • The CMS 4 compatible version checks for resource || concrete classes
  • The CMS 5 version explicitly does not reference resources at all where concrete classes should be used.

PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant