Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Magic Shield then causing stat removal disconnects both battlers from the server #6

Open
RedEnchilada opened this issue Oct 11, 2014 · 2 comments
Labels

Comments

@RedEnchilada
Copy link

Tested methods to cause stat removal include switching out the user (either manually or through an opponent's Scare Away) and using Spa Treatment to heal status effects. Server logs indicate both battlers send null msgs, and connections are then forcefully terminated. Suspecting a bug related to stat removal routines for the speed lowering or something similar?

@silverweed silverweed added the bug label Oct 11, 2014
@RedEnchilada
Copy link
Author

Found another trigger case for the bug: paralyzing a foe who then uses Nap to remove negative status effects. When running the client with the debug panel open, it complains about an uncaught exception in Connection.run. I have a hunch the error is triggered by something within the handling of rmstatus messages with no status argument (so, "heal all" messages), https://github.com/silverweed/pokepon/blob/master/gui/BattlePanel.java#L1704 and the crash happened before the "{opp} healed!" message displayed. HIGHLY SUSPECT either Pony.healStatus() or HPBar.clearStatuses() is the cause.

@silverweed
Copy link
Owner

It seems like this bug happens a bit randomly, because with a couple of tries I couldn't reproduce it. However, I believe it's due to missing null checks on ponies and HPBars, which I have added just now. If this doesn't solve the issue, would you mind taking a screenshot of the error, please?
Anyway, I'll test this further when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants