-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building the tools image fails on Mac silicon #373
Comments
chrsoo
added a commit
to chrsoo/rust-fitsio
that referenced
this issue
Dec 29, 2024
chrsoo
added a commit
to chrsoo/rust-fitsio
that referenced
this issue
Dec 29, 2024
The Dockerfile explicitly refers to the x86_64 toolchain, preventing the Dockerfile to work on an arm-based machine:
However, the clippy documentation states that clippy is included in rustup per default, making this dependency unnecessary. Removing it makes the Dockerfile build on Mac and clippy still runs as expected:
|
PR in #376 |
simonrw
pushed a commit
to chrsoo/rust-fitsio
that referenced
this issue
Jan 2, 2025
simonrw
pushed a commit
to chrsoo/rust-fitsio
that referenced
this issue
Jan 2, 2025
simonrw
pushed a commit
that referenced
this issue
Jan 2, 2025
Clippy is included by rustup per default and not needed, cf. https://doc.rust-lang.org/clippy/installation.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When following the instructions on
CONTRIBUTING.md
:... the docker build fails with the following message on a Mac with Apple silicon (M1):
It would appear that the Dockerfile (or build command) assumes an Intel-based Mac.
The text was updated successfully, but these errors were encountered: