fix: only update server in database when something was actually changed (caused servers to not stop)

Author: FllipEis

controller-runtime/src/main/kotlin/app/simplecloud/controller/runtime/server/ServerService.kt

@@ -74,48 +74,50 @@ class ServerService(
                     ?: throw StatusException(Status.NOT_FOUND.withDescription("Server not found"))
                 val wasUpdated = before != server
 
-                if (wasUpdated) {
-                    pubSubClient.publish(
-                        "event",
-                        ServerUpdateEvent.newBuilder()
-                            .setUpdatedAt(ProtobufTimestamp.fromLocalDateTime(LocalDateTime.now()))
-                            .setServerBefore(before.toDefinition()).setServerAfter(request.server).build()
-                    )
+                if (!wasUpdated) {
+                    return server.toDefinition()
+                }
+
+                pubSubClient.publish(
+                    "event",
+                    ServerUpdateEvent.newBuilder()
+                        .setUpdatedAt(ProtobufTimestamp.fromLocalDateTime(LocalDateTime.now()))
+                        .setServerBefore(before.toDefinition()).setServerAfter(request.server).build()
+                )
 
-                    pubSubClient.publish(MetricsEventNames.RECORD_METRIC, metric {
-                        metricType = "ACTIVITY_LOG"
-                        metricValue = 1L
-                        time = ProtobufTimestamp.fromLocalDateTime(LocalDateTime.now())
-                        meta.addAll(
-                            listOf(
-                                metricMeta {
-                                    dataName = "displayName"
-                                    dataValue = "${server.group} #${server.numericalId}"
-                                },
-                                metricMeta {
-                                    dataName = "status"
-                                    dataValue = "EDITED"
-                                },
-                                metricMeta {
-                                    dataName = "resourceType"
-                                    dataValue = "SERVER"
-                                },
-                                metricMeta {
-                                    dataName = "groupName"
-                                    dataValue = server.group
-                                },
-                                metricMeta {
-                                    dataName = "numericalId"
-                                    dataValue = server.numericalId.toString()
-                                },
-                                metricMeta {
-                                    dataName = "by"
-                                    dataValue = "API"
-                                }
-                            )
+                pubSubClient.publish(MetricsEventNames.RECORD_METRIC, metric {
+                    metricType = "ACTIVITY_LOG"
+                    metricValue = 1L
+                    time = ProtobufTimestamp.fromLocalDateTime(LocalDateTime.now())
+                    meta.addAll(
+                        listOf(
+                            metricMeta {
+                                dataName = "displayName"
+                                dataValue = "${server.group} #${server.numericalId}"
+                            },
+                            metricMeta {
+                                dataName = "status"
+                                dataValue = "EDITED"
+                            },
+                            metricMeta {
+                                dataName = "resourceType"
+                                dataValue = "SERVER"
+                            },
+                            metricMeta {
+                                dataName = "groupName"
+                                dataValue = server.group
+                            },
+                            metricMeta {
+                                dataName = "numericalId"
+                                dataValue = server.numericalId.toString()
+                            },
+                            metricMeta {
+                                dataName = "by"
+                                dataValue = "API"
+                            }
                         )
-                    })
-                }
+                    )
+                })
 
                 serverRepository.save(server)
                 return server.toDefinition()