From 8dcd72b3a564c0a659e5a471cf244be3c3be7a85 Mon Sep 17 00:00:00 2001 From: Adam Leach Date: Tue, 19 Nov 2024 12:07:43 +0000 Subject: [PATCH 1/2] Refactor deploy status messages for clarity --- lib/functionality/issue_deploy_check.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/functionality/issue_deploy_check.rb b/lib/functionality/issue_deploy_check.rb index 79814fa..b7988cc 100644 --- a/lib/functionality/issue_deploy_check.rb +++ b/lib/functionality/issue_deploy_check.rb @@ -16,11 +16,11 @@ def self.check_current_issue(config) case config.event_payload['action'] when 'labeled' github_summary_message += "### :boom: Deploys are blocked :boom:\n" - create_status_for_all_prs(config, 'failure', github_summary_message) + create_status_for_all_prs(config, 'failure', 'Deploys are blocked') when 'closed' if SimplyIssue.get_all_issues(config, 'issues', 'block deploys').empty? github_summary_message += "### :sparkles: You are free to deploy :sparkles:\n" - create_status_for_all_prs(config, 'success', github_summary_message) + create_status_for_all_prs(config, 'success', 'You are free to deploy') end end end From 1db39fe49f60c1246bdb90fc9fe617d433f71fed Mon Sep 17 00:00:00 2001 From: Adam Leach Date: Tue, 19 Nov 2024 12:11:59 +0000 Subject: [PATCH 2/2] Update deploy status handling to include summary messages --- lib/functionality/issue_deploy_check.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/functionality/issue_deploy_check.rb b/lib/functionality/issue_deploy_check.rb index b7988cc..188058b 100644 --- a/lib/functionality/issue_deploy_check.rb +++ b/lib/functionality/issue_deploy_check.rb @@ -16,22 +16,22 @@ def self.check_current_issue(config) case config.event_payload['action'] when 'labeled' github_summary_message += "### :boom: Deploys are blocked :boom:\n" - create_status_for_all_prs(config, 'failure', 'Deploys are blocked') + create_status_for_all_prs(config, 'failure', 'Deploys are blocked', github_summary_message) when 'closed' if SimplyIssue.get_all_issues(config, 'issues', 'block deploys').empty? github_summary_message += "### :sparkles: You are free to deploy :sparkles:\n" - create_status_for_all_prs(config, 'success', 'You are free to deploy') + create_status_for_all_prs(config, 'success', 'You are free to deploy', github_summary_message) end end end - def self.create_status_for_all_prs(config, status, message) + def self.create_status_for_all_prs(config, status, status_message, message) config.client.auto_paginate = true all_pull_requests = SimplyIssue.get_all_issues(config, 'pull_request') all_pull_requests.each do |pr| result = config.client.create_status( config.app_repo, pr['head']['sha'], status, - description: message, + description: status_message, context: context_name, target_url: config.event_payload['html_url'] )