Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on an Electron app #422

Closed
akashnimare opened this issue Sep 16, 2016 · 3 comments
Closed

Feedback on an Electron app #422

akashnimare opened this issue Sep 16, 2016 · 3 comments

Comments

@akashnimare
Copy link

akashnimare commented Sep 16, 2016

Hey @sindresorhus 😄

I have built a desktop menubar app called Foco. It's like noisli but for desktop. It would be awesome if you could try it out and give some valuable feedback.

https://github.com/akashnimare/foco

@akashnimare akashnimare changed the title Feedback for a electron app Feedback for an electron app Sep 18, 2016
@sindresorhus
Copy link
Owner

sindresorhus commented Sep 28, 2016

Nice work. I tried it out on macOS.

  • The app icon doesn't fit in on macOS. It should be circular or less round and tilted. The artwork in the icon is also too much out on the edge. Give it some room to breath. The artwork is also a bit cluttered. I would go for something simpler.
  • The menubar icon is not retina, so it's pixelated.
  • The menubar icon should not be colored and should be simpler. Also make it a templated image (see Electron) so it works fine in dark mode too.
  • There should be a way to exit the app without having to press Cmd+Q. Usually this is done through a preferences icon that opens a menu that contains a Quit Foco item at the bottom.
  • Drop the X in the popover. The popover will close when losing focus or clicking the icon again.
  • The popover arrow does not match the rest of the popover.
  • The popover is not round at the top, only bottom.
  • Don't uppercase the different sound names.
  • I would add a nice icon for each sound type. See http://noiz.io/ for how to nicely do it.
  • You should disable ability to select the text and other things. user-select: none.
  • The toggle button could use some work. I would use the light or flat one here: https://codepen.io/mallendeo/pen/eLIiG
  • If I click the menubar icon many times it doesn't always toggle the popover. It works if I wait some seconds between clicking.
  • The popover is placed incorrectly if the menubar is automatically hidden/shown. It's placed at the top of the screen, instead of below the menubar.
  • The popover should have a pause button, so I can pause everything without having to click each toggle.
  • Use electron-builder to build the app. It's much better than electron-packager, and you get Windows/linux installers akashnimare/foco#2 solved with almost no extra work.

@sindresorhus sindresorhus changed the title Feedback for an electron app Feedback on an Electron app Sep 28, 2016
@akashnimare
Copy link
Author

@sindresorhus thanks for the in depth feedback 🙌 . Before taking this project to ProductHunt, I'll make sure to sort out all the points you have mentioned.

@lacymorrow
Copy link

These are great tips for Electron in general!
Almost a basic checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants