You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Support servername https option. This alows user to send requests to servers that don't have a proper domain name, but use a certificate with a known CN/SAN that should be verified.
Describe the feature
Tells node's tls module what domain name to expect in the certificate returned by the server. No login needs to be added to got.
To support this, the only change needed to got is to add servername: undefined to the https object of defaultInternals in options.js. Without this, the set https(value) setter throws. Maybe a string type assertion in the setter would be good too.
Checklist
I have read the documentation and made sure this feature doesn't already exist.
The text was updated successfully, but these errors were encountered:
What problem are you trying to solve?
Support
servername
https option. This alows user to send requests to servers that don't have a proper domain name, but use a certificate with a known CN/SAN that should be verified.Describe the feature
Tells node's tls module what domain name to expect in the certificate returned by the server. No login needs to be added to
got
.To support this, the only change needed to got is to add
servername: undefined
to thehttps
object ofdefaultInternals
inoptions.js
. Without this, theset https(value)
setter throws. Maybe a string type assertion in the setter would be good too.Checklist
The text was updated successfully, but these errors were encountered: