Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] open doesn't close the app and the socket on mac and linux #287

Open
KarishmaGhiya opened this issue Jun 10, 2022 · 0 comments
Open

Comments

@KarishmaGhiya
Copy link

KarishmaGhiya commented Jun 10, 2022

Issue description :

  • The open dependency doesn't close the socket even after the app has closed on Mac and Linux

Reproduce steps -

Scenario 1

open("https://google.com", { wait: true }).then(() => console.log('closed'))

The above doesn't close the socket and doesn't print "closed" on Mac and Linux OS. Works as expected on windows

Scenario 2

When we use the newInstance argument, it opens on a new browser tab on MacOS but closes the socket as expected. However, no such workaround is available for linux OS.

open("https://google.com", { newInstance: true, wait: true }).then(() => console.log('closed'))

cc: @mpodwysocki

@KarishmaGhiya KarishmaGhiya changed the title open doesn't close the app and the socket on mac and linux [bug] open doesn't close the app and the socket on mac and linux Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant