From 549c40d2f8bc0ccd7980002b56b7ba52823ceec3 Mon Sep 17 00:00:00 2001 From: mshanemc Date: Fri, 5 Jan 2024 11:52:53 -0600 Subject: [PATCH 1/2] fix: put target/url as last argument on mac --- index.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/index.js b/index.js index 3e1a5af..dfef2a6 100644 --- a/index.js +++ b/index.js @@ -238,14 +238,14 @@ const baseOpen = async options => { } } - if (options.target) { - cliArguments.push(options.target); - } - if (platform === 'darwin' && appArguments.length > 0) { cliArguments.push('--args', ...appArguments); } + if (options.target) { + cliArguments.push(options.target); + } + const subprocess = childProcess.spawn(command, cliArguments, childProcessOptions); if (options.wait) { From 5ff1dbb43b0c45104c66b25e775cf6769d17173c Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Sun, 7 Jan 2024 12:45:56 +0700 Subject: [PATCH 2/2] Update index.js --- index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/index.js b/index.js index dfef2a6..7af98a3 100644 --- a/index.js +++ b/index.js @@ -242,6 +242,7 @@ const baseOpen = async options => { cliArguments.push('--args', ...appArguments); } + // This has to come after `--args`. if (options.target) { cliArguments.push(options.target); }