fix: Views should dispose of their own buffers even when in use

Author: sindrets

lua/diffview/lib.lua

@@ -195,14 +195,17 @@ function M.get_prev_non_view_tabpage()
 end
 
 ---@param bufnr integer
+---@param ignore? vcs.File[]
 ---@return boolean
-function M.is_buf_in_use(bufnr)
+function M.is_buf_in_use(bufnr, ignore)
   for _, view in ipairs(M.views) do
     if view:instanceof(StandardView.__get()) then
       ---@cast view StandardView
       for _, file in ipairs(view.cur_entry and view.cur_entry.layout:files() or {}) do
         if file:is_valid() and file.bufnr == bufnr then
-          return true
+          if not (ignore and vim.tbl_contains(ignore, file)) then
+            return true
+          end
         end
       end
     end

lua/diffview/vcs/file.lua

@@ -108,7 +108,7 @@ function File:destroy(force)
   self.active = false
   self:detach_buffer()
 
-  if force or self.rev.type ~= RevType.LOCAL and not lib.is_buf_in_use(self.bufnr) then
+  if force or self.rev.type ~= RevType.LOCAL and not lib.is_buf_in_use(self.bufnr, { self }) then
     File.safe_delete_buf(self.bufnr)
   end
 end
@@ -368,7 +368,7 @@ function File:dispose_buffer()
   if self.bufnr and api.nvim_buf_is_loaded(self.bufnr) then
     self:detach_buffer()
 
-    if not lib.is_buf_in_use(self.bufnr) then
+    if not lib.is_buf_in_use(self.bufnr, { self }) then
       File.safe_delete_buf(self.bufnr)
     end