docker runtime healthcheck: initialize LastUpdated to the current time

Author: singholt

agent/doctor/docker_runtime_healthcheck.go

@@ -25,6 +25,8 @@ import (
 
 const systemPingTimeout = time.Second * 2
 
+var timeNow = time.Now
+
 type dockerRuntimeHealthcheck struct {
 	// HealthcheckType is the reported healthcheck type
 	HealthcheckType string `json:"HealthcheckType,omitempty"`
@@ -45,12 +47,13 @@ type dockerRuntimeHealthcheck struct {
 }
 
 func NewDockerRuntimeHealthcheck(client dockerapi.DockerClient) *dockerRuntimeHealthcheck {
-	nowTime := time.Now()
+	nowTime := timeNow()
 	return &dockerRuntimeHealthcheck{
 		HealthcheckType:  doctor.HealthcheckTypeContainerRuntime,
 		Status:           doctor.HealthcheckStatusInitializing,
 		TimeStamp:        nowTime,
 		StatusChangeTime: nowTime,
+		LastTimeStamp:    nowTime,
 		client:           client,
 	}
 }

agent/doctor/docker_runtime_healthcheck_test.go

@@ -19,8 +19,23 @@ func TestNewDockerRuntimeHealthCheck(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	defer ctrl.Finish()
 	mockDockerClient := mock_dockerapi.NewMockDockerClient(ctrl)
-	dockerRuntimeHealthCheck := NewDockerRuntimeHealthcheck(mockDockerClient)
-	assert.Equal(t, doctor.HealthcheckStatusInitializing, dockerRuntimeHealthCheck.Status)
+
+	// Mock the time to have predictable values
+	mockTime := time.Now()
+	originalTimeNow := timeNow
+	timeNow = func() time.Time { return mockTime }
+	defer func() { timeNow = originalTimeNow }()
+
+	expectedDockerRuntimeHealthcheck := &dockerRuntimeHealthcheck{
+		HealthcheckType:  doctor.HealthcheckTypeContainerRuntime,
+		Status:           doctor.HealthcheckStatusInitializing,
+		TimeStamp:        mockTime,
+		StatusChangeTime: mockTime,
+		LastTimeStamp:    mockTime,
+		client:           mockDockerClient,
+	}
+	actualDockerRuntimeHealthcheck := NewDockerRuntimeHealthcheck(mockDockerClient)
+	assert.Equal(t, expectedDockerRuntimeHealthcheck, actualDockerRuntimeHealthcheck)
 }
 
 func TestRunCheck(t *testing.T) {