Remove tests cache on correct solution change (#159)

* Remove tests cache when correct solutions changes

* Add tests

* Refactor

Author: MasloMaslane

src/sinol_make/commands/gen/__init__.py

@@ -8,7 +8,7 @@
 from sinol_make import util
 from sinol_make.commands.gen import gen_util
 from sinol_make.structs.gen_structs import OutputGenerationArguments
-from sinol_make.helpers import parsers, package_util
+from sinol_make.helpers import parsers, package_util, cache
 from sinol_make.interfaces.BaseCommand import BaseCommand
 
 
@@ -108,6 +108,7 @@ def run(self, args: argparse.Namespace):
         self.task_id = package_util.get_task_id()
         package_util.validate_test_names(self.task_id)
         util.change_stack_size_to_unlimited()
+        cache.check_correct_solution(self.task_id)
         if self.ins:
             self.ingen = gen_util.get_ingen(self.task_id, args.ingen_path)
             print(util.info(f'Using ingen file {os.path.basename(self.ingen)}'))

src/sinol_make/helpers/cache.py

@@ -131,3 +131,30 @@ def check_can_access_cache():
     except PermissionError:
         util.exit_with_error("You don't have permission to access the `.cache/` directory. "
                              "`sinol-make` needs to be able to write to this directory.")
+
+
+def has_file_changed(file_path: str) -> bool:
+    """
+    Checks if file has changed since last compilation.
+    :param file_path: Path to the file
+    :return: True if file has changed, False otherwise
+    """
+    try:
+        info = get_cache_file(file_path)
+        return info.md5sum != util.get_file_md5(file_path)
+    except FileNotFoundError:
+        return True
+
+
+def check_correct_solution(task_id: str):
+    """
+    Checks if correct solution has changed. If it did, removes cache for input files.
+    :param task_id: Task id
+    """
+    try:
+        solution = package_util.get_correct_solution(task_id)
+    except FileNotFoundError:
+        return
+
+    if has_file_changed(solution) and os.path.exists(os.path.join(os.getcwd(), 'in', '.md5sums')):
+        os.unlink(os.path.join(os.getcwd(), 'in', '.md5sums'))

src/sinol_make/helpers/package_util.py

@@ -146,6 +146,18 @@ def get_solutions(task_id: str, args_solutions: Union[List[str], None] = None) -
         return sorted(solutions, key=lambda solution: get_executable_key(solution, task_id))
 
 
+def get_correct_solution(task_id: str) -> str:
+    """
+    Returns path to correct solution.
+    :param task_id: Task id.
+    :return: Path to correct solution.
+    """
+    correct_solution = get_solutions(task_id, [f'{task_id}.*'])
+    if len(correct_solution) == 0:
+        raise FileNotFoundError("Correct solution not found.")
+    return os.path.join(os.getcwd(), "prog", correct_solution[0])
+
+
 def get_file_name(file_path):
     return os.path.split(file_path)[1]
 

tests/commands/gen/test_integration.py

@@ -4,9 +4,10 @@
 import glob
 
 from sinol_make import configure_parsers
+from sinol_make import util as sm_util
 from sinol_make.commands.gen import Command
 from sinol_make.commands.gen import gen_util
-from sinol_make.helpers import package_util, paths
+from sinol_make.helpers import package_util, paths, cache
 from tests.fixtures import *
 from tests import util
 
@@ -47,6 +48,9 @@ def test_correct_inputs(capsys, create_package):
     """
     Test `ingen` command with all unchanged inputs.
     """
+    task_id = package_util.get_task_id()
+    correct_solution = package_util.get_correct_solution(task_id)
+    cache.save_compiled(correct_solution, "exe")
     simple_run()
     md5_sums = get_md5_sums(create_package)
 
@@ -63,6 +67,9 @@ def test_changed_inputs(capsys, create_package):
     """
     Test `ingen` command with changed inputs.
     """
+    task_id = package_util.get_task_id()
+    correct_solution = package_util.get_correct_solution(task_id)
+    cache.save_compiled(correct_solution, "exe")
     simple_run()
     md5_sums = get_md5_sums(create_package)
     correct_md5 = md5_sums.copy()
@@ -152,3 +159,29 @@ def test_missing_output_files(create_package):
         assert os.path.exists(outs[0])
         shutil.rmtree(paths.get_cache_path())
         os.unlink(os.path.join(package_path, "in", ".md5sums"))
+
+
+@pytest.mark.parametrize("create_package", [util.get_shell_ingen_pack_path(), util.get_simple_package_path()],
+                         indirect=True)
+def test_correct_solution_changed(create_package):
+    """
+    Test if `.md5sums` is deleted when correct solution is changed.
+    """
+    package_path = create_package
+    task_id = package_util.get_task_id()
+    md5sums = os.path.join(package_path, "in", ".md5sums")
+    simple_run()
+    assert os.path.exists(md5sums)
+    outputs = {}
+    for output in glob.glob(os.path.join(package_path, "out", "*.out")):
+        outputs[os.path.basename(output)] = sm_util.get_file_md5(output)
+
+    solution = package_util.get_correct_solution(task_id)
+    with open(os.path.join(solution), "w") as f:
+        f.write("int main() {}")
+    cache.check_correct_solution(task_id)
+    assert not os.path.exists(md5sums)
+    simple_run()
+    assert os.path.exists(md5sums)
+    for output in glob.glob(os.path.join(package_path, "out", "*.out")):
+        assert outputs[os.path.basename(output)] != sm_util.get_file_md5(output)