From 9d696106effc2533c8f5effc758b48d5a92ac2bd Mon Sep 17 00:00:00 2001
From: soulgalore <peter@soulgalore.com>
Date: Fri, 7 Jun 2024 05:39:46 +0200
Subject: [PATCH] Make sure the extra run happens after the engine stopped

---
 bin/browsertime.js | 69 +++++++++++++++++++++++-----------------------
 1 file changed, 35 insertions(+), 34 deletions(-)

diff --git a/bin/browsertime.js b/bin/browsertime.js
index a7df843a9..92b53aa2e 100755
--- a/bin/browsertime.js
+++ b/bin/browsertime.js
@@ -123,40 +123,6 @@ async function run(urls, options) {
         );
       }
 
-      if (options.enableProfileRun || options.enableVideoRun) {
-        log.info('Make one extra run to collect trace/video information');
-        options.iterations = 1;
-        if (options.enableProfileRun) {
-          if (options.browser === 'firefox') {
-            options.firefox.geckoProfiler = true;
-          } else if (options.browser === 'chrome') {
-            options.chrome.timeline = true;
-            options.cpu = true;
-            options.chrome.enableTraceScreenshots = true;
-            options.chrome.traceCategory = [
-              'disabled-by-default-v8.cpu_profiler'
-            ];
-          }
-        }
-        if (options.enableVideoRun) {
-          if (options.video === true) {
-            log.error(
-              'You can only configure video run if you do not collect any video'
-            );
-            // This is a hack to not get an error
-            options.video = false;
-            options.visualMetrics = false;
-          } else {
-            options.video = true;
-            options.visualMetrics = true;
-          }
-        }
-        const traceEngine = new Engine(options);
-        await traceEngine.start();
-        await traceEngine.runMultiple(urls, scriptsByCategory);
-        await traceEngine.stop();
-      }
-
       await Promise.all(saveOperations);
 
       const resultDirectory = relative(process.cwd(), storageManager.directory);
@@ -186,6 +152,41 @@ async function run(urls, options) {
         process.exitCode = 1;
       }
     }
+
+    if (options.enableProfileRun || options.enableVideoRun) {
+      log.info('Make one extra run to collect trace/video information');
+      options.iterations = 1;
+      if (options.enableProfileRun) {
+        if (options.browser === 'firefox') {
+          options.firefox.geckoProfiler = true;
+        } else if (options.browser === 'chrome') {
+          options.chrome.timeline = true;
+          options.cpu = true;
+          options.chrome.enableTraceScreenshots = true;
+          options.chrome.traceCategory = [
+            'disabled-by-default-v8.cpu_profiler'
+          ];
+        }
+      }
+      if (options.enableVideoRun) {
+        if (options.video === true) {
+          log.error(
+            'You can only configure video run if you do not collect any video'
+          );
+          // This is a hack to not get an error
+          options.video = false;
+          options.visualMetrics = false;
+        } else {
+          options.video = true;
+          options.visualMetrics = true;
+        }
+      }
+      const traceEngine = new Engine(options);
+      await traceEngine.start();
+      await traceEngine.runMultiple(urls, scriptsByCategory);
+      await traceEngine.stop();
+      log.info('Extra run finished');
+    }
   } catch (error) {
     log.error('Error running browsertime', error);
     process.exitCode = 1;