refactor: remove snippet config

Author: siyul-park

pkg/plugin/controllx/builder.go

@@ -10,10 +10,7 @@ func AddToScheme() func(*scheme.Scheme) error {
 	return func(s *scheme.Scheme) error {
 		s.AddKnownType(KindSnippet, &SnippetSpec{})
 		s.AddCodec(KindSnippet, scheme.CodecWithType[*SnippetSpec](func(spec *SnippetSpec) (node.Node, error) {
-			return NewSnippetNode(SnippetNodeConfig{
-				Lang: spec.Lang,
-				Code: spec.Code,
-			})
+			return NewSnippetNode(spec.Lang, spec.Code)
 		}))
 
 		s.AddKnownType(KindSwitch, &SwitchSpec{})

pkg/plugin/controllx/snippet.go

@@ -18,12 +18,6 @@ import (
 	"github.com/xiatechs/jsonata-go"
 )
 
-// SnippetNodeConfig holds the configuration for creating a SnippetNode.
-type SnippetNodeConfig struct {
-	Lang string
-	Code string
-}
-
 // SnippetNode represents a node that runs a snippet of code.
 type SnippetNode struct {
 	*node.OneToOneNode
@@ -57,13 +51,10 @@ var (
 var _ node.Node = (*SnippetNode)(nil)
 var _ scheme.Spec = (*SnippetSpec)(nil)
 
-// NewSnippetNode creates a new SnippetNode with the given configuration.
-func NewSnippetNode(config SnippetNodeConfig) (*SnippetNode, error) {
+// NewSnippetNode creates a new SnippetNode.
+func NewSnippetNode(lang, code string) (*SnippetNode, error) {
 	defer func() { _ = recover() }()
 
-	lang := config.Lang
-	code := config.Code
-
 	run, err := compile(lang, code)
 	if err != nil {
 		return nil, err

pkg/plugin/controllx/snippet_test.go

@@ -16,10 +16,7 @@ import (
 )
 
 func TestNewSnippetNode(t *testing.T) {
-	n, err := NewSnippetNode(SnippetNodeConfig{
-		Lang: LangJSON,
-		Code: "{}",
-	})
+	n, err := NewSnippetNode(LangJSON, "")
 	assert.NoError(t, err)
 	assert.NotNil(t, n)
 
@@ -28,14 +25,11 @@ func TestNewSnippetNode(t *testing.T) {
 
 func TestSnippetNode_Send(t *testing.T) {
 	t.Run(LangTypescript, func(t *testing.T) {
-		n, _ := NewSnippetNode(SnippetNodeConfig{
-			Lang: LangTypescript,
-			Code: `
+		n, _ := NewSnippetNode(LangTypescript, `
 function main(inPayload: any): any {
 	return inPayload;
 }
-			`,
-		})
+		`)
 		defer func() { _ = n.Close() }()
 
 		io := port.New()
@@ -64,14 +58,11 @@ function main(inPayload: any): any {
 	})
 
 	t.Run(LangJavascript, func(t *testing.T) {
-		n, _ := NewSnippetNode(SnippetNodeConfig{
-			Lang: LangJavascript,
-			Code: `
+		n, _ := NewSnippetNode(LangTypescript, `
 function main(inPayload) {
 	return inPayload;
 }
-			`,
-		})
+		`)
 		defer func() { _ = n.Close() }()
 
 		io := port.New()
@@ -102,10 +93,7 @@ function main(inPayload) {
 	t.Run(LangJSON, func(t *testing.T) {
 		data := faker.UUIDHyphenated()
 
-		n, _ := NewSnippetNode(SnippetNodeConfig{
-			Lang: LangJSON,
-			Code: fmt.Sprintf("\"%s\"", data),
-		})
+		n, _ := NewSnippetNode(LangJSON, fmt.Sprintf("\"%s\"", data))
 		defer func() { _ = n.Close() }()
 
 		io := port.New()
@@ -134,10 +122,7 @@ function main(inPayload) {
 	})
 
 	t.Run(LangJSONata, func(t *testing.T) {
-		n, _ := NewSnippetNode(SnippetNodeConfig{
-			Lang: LangJSONata,
-			Code: "$",
-		})
+		n, _ := NewSnippetNode(LangJSONata, "$")
 		defer func() { _ = n.Close() }()
 
 		io := port.New()
@@ -168,14 +153,11 @@ function main(inPayload) {
 
 func BenchmarkSnippetNode_Send(b *testing.B) {
 	b.Run(LangTypescript, func(b *testing.B) {
-		n, _ := NewSnippetNode(SnippetNodeConfig{
-			Lang: LangTypescript,
-			Code: `
+		n, _ := NewSnippetNode(LangTypescript, `
 function main(inPayload: any): any {
 	return inPayload;
 }
-				`,
-		})
+		`)
 		defer func() { _ = n.Close() }()
 
 		io := port.New()
@@ -199,14 +181,11 @@ function main(inPayload: any): any {
 	})
 
 	b.Run(LangJavascript, func(b *testing.B) {
-		n, _ := NewSnippetNode(SnippetNodeConfig{
-			Lang: LangJavascript,
-			Code: `
+		n, _ := NewSnippetNode(LangJavascript, `
 function main(inPayload) {
 	return inPayload;
 }
-				`,
-		})
+		`)
 		defer func() { _ = n.Close() }()
 
 		io := port.New()
@@ -230,10 +209,7 @@ function main(inPayload) {
 	})
 
 	b.Run(LangJSON, func(b *testing.B) {
-		n, _ := NewSnippetNode(SnippetNodeConfig{
-			Lang: LangJSON,
-			Code: fmt.Sprintf("\"%s\"", faker.UUIDHyphenated()),
-		})
+		n, _ := NewSnippetNode(LangJSON, fmt.Sprintf("\"%s\"", faker.UUIDHyphenated()))
 		defer func() { _ = n.Close() }()
 
 		io := port.New()
@@ -257,10 +233,7 @@ function main(inPayload) {
 	})
 
 	b.Run(LangJSONata, func(b *testing.B) {
-		n, _ := NewSnippetNode(SnippetNodeConfig{
-			Lang: LangJSONata,
-			Code: "$",
-		})
+		n, _ := NewSnippetNode(LangJSONata, "$")
 		defer func() { _ = n.Close() }()
 
 		io := port.New()