Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Test Node #225

Open
siyul-park opened this issue Jan 26, 2025 · 0 comments
Open

Implement Test Node #225

siyul-park opened this issue Jan 26, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@siyul-park
Copy link
Owner

Objective

The goal of this issue is to set up a test flow to verify success or failure. The success of the test will be determined based on the results of the workflow execution, clearly distinguishing between success and failure.

Current System State

A Runner has been implemented under the testing package to execute tests and deliver results. This component handles the running of workflows and manages their success or failure based on the provided configurations.

Proposed Changes

To improve the test flow and verification, the following modifications are suggested:

Test Success Verification (Basic Example)

kind: test
ports:
  out:
    - name: sub
      port: in

If the sub workflow does not respond with an error, the test is considered successful. If an error is returned, the test is considered failed.

Test Success Verification (Extended Example)

kind: test
ports:
  out[0]:
    - name: sub
      port: in
  out[1]:
    - name: assert
      port: in

The sub workflow connected to out[0] is executed, and the result is checked to determine the success of the test.
The validation node connected to out[1] receives [index, value] as inputs. Here, index represents the position of value in the frame, and value defines the payload of the packet to verify. Initially, index is set to -1, and value holds the result of the sub workflow execution.
If the validation node fails, an error response is returned, and the test is considered failed.

Additional Information

In order to improve test reliability, it may be beneficial to add more detailed error handling, providing better context for failure scenarios. Additionally, implementing logging for the Runner could enhance the visibility of the test flow, making it easier to debug issues and track the success or failure of individual components within the workflow.

@siyul-park siyul-park added the enhancement New feature or request label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant