Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Add GP Premium as a dependency #81

Closed
marekdedic opened this issue Aug 29, 2019 · 3 comments
Closed

Add GP Premium as a dependency #81

marekdedic opened this issue Aug 29, 2019 · 3 comments

Comments

@marekdedic
Copy link
Contributor

Since we will probably build upon GP Premium, we should add it as a dependency. Or Ideally make it gracefully lose features...

@marekdedic marekdedic added this to the Version 1.0.0 milestone Aug 29, 2019
@kalich5
Copy link
Member

kalich5 commented Aug 29, 2019

Certainly the function must disappear. The FREE template should not depend on the PRO plugin. It can be at most as a link that the extension will add more features.

@marekdedic
Copy link
Contributor Author

Ok, what about functionality that is currently implemented in our theme, but in GeneratePress, it's part of a Premium module? Should we remove it, so as not to clash with parent theme, or keep it or what?

@marekdedic
Copy link
Contributor Author

GP Premium functionality will be re-implemented if premium isn't enabled. This is very few items, so it shouldn't be a problem with GP author. See #97

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants