From 6a2ee53ea61bebd2c16300cfd08de3a74c5829bb Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 3 Dec 2025 19:18:35 +0000 Subject: [PATCH 1/2] Initial plan From 32e29d9236db8c5e41de84f896b90f1f59890981 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 3 Dec 2025 19:23:48 +0000 Subject: [PATCH 2/2] Remove commented-out code and placeholder comments from exchange_hankel.py Co-authored-by: skilledwolf <18141588+skilledwolf@users.noreply.github.com> --- src/quantumhall_matrixelements/exchange_hankel.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/quantumhall_matrixelements/exchange_hankel.py b/src/quantumhall_matrixelements/exchange_hankel.py index 345513d..e63d52d 100644 --- a/src/quantumhall_matrixelements/exchange_hankel.py +++ b/src/quantumhall_matrixelements/exchange_hankel.py @@ -18,11 +18,9 @@ def _N_order(n1: int, m1: int, n2: int, m2: int) -> int: - #return (n1 - m1) - (m2 - n2) return ((n1 - m1) + (m2 - n2)) def _parity_factor(N: int) -> int: - #return (-1) ** ((N + abs(N)) // 2) return (-1) ** ((N - abs(N)) // 2) @lru_cache(maxsize=None) @@ -141,9 +139,8 @@ def get_exchange_kernels_hankel( phase = -N * G_angles phase_by_N[int(N)] = (np.cos(phase) + 1j * np.sin(phase)) * _parity_factor(int(N)) - # Small lookup for internal (i)^(d1-d2), indexed by d1,d2 in [0..nmax-1] + # Small lookup for internal (i)^(d1+d2), indexed by d1,d2 in [0..nmax-1] d_vals = np.arange(nmax, dtype=int) - #phase_internal_table = (1j) ** (d_vals[:, None] - d_vals[None, :]) # (nmax,nmax) phase_internal_table = (1j) ** (d_vals[:, None] + d_vals[None, :]) # (nmax,nmax) d_lookup = np.abs(np.subtract.outer(np.arange(nmax), np.arange(nmax))) # (nmax,nmax) @@ -197,7 +194,7 @@ def integrand(q): # Angular/internal phases phase_internal = phase_internal_table[d1, d2] phase_angle = phase_by_N[N] - extra_sgn = (-1)**(n2-m2) # CHANGED HERE NEGATIVE B FIELD + extra_sgn = (-1)**(n2-m2) Xs[:, n1, m1, n2, m2] = phase_internal * phase_angle * X_radial * extra_sgn