Joiner family parameter names #751
Closed
Vincent-Maladiere
started this conversation in
Polls
Replies: 1 comment
-
as mentioned in 742 we can add the |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Parameters names
During the skrub meeting on 25/09, we discussed bringing more consistency to the parameter names of Joiner-like transformers. The current conclusions are to match pandas API
pd.merge
withfuzzy_join
function to ease adoption while differentiating from pandas for the transformer classes.This table recaps the current consensus:
Multiple tables classes
We also agreed on only using a single auxiliary table in
Joiner
,InterpolateJoiner
, andAggJoiner
. The reason is to make these API easier to use. For each object, we will create aMulti
version to deal with multiple tables, respectivelyMultiJoiner
,MultiInterpolateJoiner
,MultiAggJoiner
. These objects will have the same parameters as their single table version.Classes names
Also, we voted on naming classes either verbs (e.g.
Join
) or nouns (e.g.Joiner
) throughout all skrub API. The vote leaned on verbs rather than nouns (5 against 4). We can use this poll to continue this discussion and change our votes if we want to.cc @jovan-stojanovic, @jeromedockes, @myungkim930, @rcap107, @GaelVaroquaux, @flefebv, @LeoGrin, @tigerchen52
1 vote ·
Beta Was this translation helpful? Give feedback.
All reactions