Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror golang namespace structure #68

Open
olemis opened this issue Aug 10, 2018 · 2 comments
Open

Mirror golang namespace structure #68

olemis opened this issue Aug 10, 2018 · 2 comments
Assignees
Labels
stdev wip Work in progress
Milestone

Comments

@olemis
Copy link
Contributor

olemis commented Aug 10, 2018

Include pyskycoin API names in specific submodules under skycoin package and corresponding classes whenever appropriate . This will imply renaming some functions / variables e.g. skycoin.SKY_cipher_SecKey_Hex => skycoin.cipher.SecKey.Hex , skycoin.cipher_SecKey() => skycoin.cipher.SecKey(), etc, ...

@olemis olemis added stdev wip Work in progress labels Aug 10, 2018
@olemis olemis assigned stdevKoky and unassigned m4yk3ldev Aug 10, 2018
@stdevAlDen
Copy link
Contributor

Hi, I am not sure if this is possible, libskycoin library doesn't export package name.
If we were to divide in submodules in Pyskycoin we would have to make our own generator :). Or maybe we could use some kind of plugin for swig.
Swig does have an option for specifying a namespace, for this option is for C#, and the namespace is applied to the whole set of functions.
I am saying this based on what I have read about swig. As far as I know this is not possible. But there is a section in swig documentation entitled "Extending SWIG to support new languages", maybe, just maybe, we could use this to divide libskycoin functions into submodules.

@olemis
Copy link
Contributor Author

olemis commented Aug 10, 2018

@stdevEclipse generated files remain the same as they are now. This issue is for creating new files following the package / class structure mentioned above with code invoking SWIG-generated functions under-the-hood

@olemis olemis assigned olemis and unassigned stdevKoky Sep 1, 2018
stdevKoky added a commit to simelo/pyskycoin.orig that referenced this issue Sep 3, 2018
stdevKoky added a commit to simelo/pyskycoin.orig that referenced this issue Sep 3, 2018
stdevKoky added a commit to simelo/pyskycoin.orig that referenced this issue Sep 4, 2018
stdevKoky added a commit to simelo/pyskycoin.orig that referenced this issue Oct 11, 2018
@olemis olemis added this to the 0.26.0 milestone Dec 26, 2018
@olemis olemis modified the milestones: 0.26.0, 0.25.1 Jan 17, 2019
@olemis olemis modified the milestones: 0.25.1, 0.26.1 May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdev wip Work in progress
Projects
None yet
Development

No branches or pull requests

4 participants