Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skywire-services can't use dmsg v1.3.11 #29

Closed
0pcom opened this issue Jul 21, 2023 · 1 comment
Closed

skywire-services can't use dmsg v1.3.11 #29

0pcom opened this issue Jul 21, 2023 · 1 comment

Comments

@0pcom
Copy link
Collaborator

0pcom commented Jul 21, 2023

when go.,mod is updated to the latest commits to dmsg, or even to the tagged version v1.3.11; skywire-services won't work with it, producing the following error:

# github.com/skycoin/skywire-services/cmd/route-finder/commands
vendor/github.com/skycoin/skywire-services/cmd/route-finder/commands/root.go:174:102: too many arguments in call to dmsghttp.ListenAndServe
	have (context.Context, "github.com/skycoin/skywire-utilities/pkg/cipher".PubKey, "github.com/skycoin/skywire-utilities/pkg/cipher".SecKey, *api.API, disc.APIClient, uint16, *dmsg.Config, *dmsg.Client, *"github.com/skycoin/skywire-utilities/pkg/logging".Logger)
	want (context.Context, "github.com/skycoin/skywire-utilities/pkg/cipher".SecKey, http.Handler, disc.APIClient, uint16, *dmsg.Client, *"github.com/skycoin/skywire-utilities/pkg/logging".Logger)
# github.com/skycoin/skywire-services/cmd/transport-discovery/commands
vendor/github.com/skycoin/skywire-services/cmd/transport-discovery/commands/root.go:209:103: too many arguments in call to dmsghttp.ListenAndServe
	have (context.Context, "github.com/skycoin/skywire-utilities/pkg/cipher".PubKey, "github.com/skycoin/skywire-utilities/pkg/cipher".SecKey, *api.API, disc.APIClient, uint16, *dmsg.Config, *dmsg.Client, *"github.com/skycoin/skywire-utilities/pkg/logging".Logger)
	want (context.Context, "github.com/skycoin/skywire-utilities/pkg/cipher".SecKey, http.Handler, disc.APIClient, uint16, *dmsg.Client, *"github.com/skycoin/skywire-utilities/pkg/logging".Logger)
# github.com/skycoin/skywire-services/cmd/address-resolver/commands
vendor/github.com/skycoin/skywire-services/cmd/address-resolver/commands/root.go:213:102: too many arguments in call to dmsghttp.ListenAndServe
	have (context.Context, "github.com/skycoin/skywire-utilities/pkg/cipher".PubKey, "github.com/skycoin/skywire-utilities/pkg/cipher".SecKey, *api.API, disc.APIClient, uint16, *dmsg.Config, *dmsg.Client, *"github.com/skycoin/skywire-utilities/pkg/logging".Logger)
	want (context.Context, "github.com/skycoin/skywire-utilities/pkg/cipher".SecKey, http.Handler, disc.APIClient, uint16, *dmsg.Client, *"github.com/skycoin/skywire-utilities/pkg/logging".Logger)

PubKey was removed as an input to the function as its easily possible to derive the public key from the secret key.

dmsg.Config was removed as it was unused, but it should be used at some point as the services should attempt to connect to all dmsg servers by setting min_sessions to 0 in the dmsg.Config

#28 demonstrates this issue

@mrpalide
Copy link
Contributor

mrpalide commented Feb 1, 2024

Fixed and now skywire-service use dmsg v1.3.14

@mrpalide mrpalide closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants