Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use address resolver to determine if certain transport types can be established to remote visors #1945

Open
0pcom opened this issue Mar 5, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@0pcom
Copy link
Collaborator

0pcom commented Mar 5, 2025

Currently there exists logic to prevent automatic stcpr transport creation to non-public visors - which may be overridden by the -f flag of skywire cli tp add

This logic is actually implemented incorrectly as it blocks creation of stcpr transports regardless of if the visor is public or not.

In the second place, it was the wrong choice to use the public visor service discovery to make this determination.

the address resolver should be used to predetermine what transport types may be created to remote visors. including sudph. And we should show an error message based on if the visor attempting to be transported is shown to be available for certain transport types.

the -f flag should force a transport creation attempt for certain types of transports.

@0pcom 0pcom added the bug Something isn't working label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant