Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable -Wshadow -Werror=shadow #48

Open
JJL772 opened this issue Jul 7, 2023 · 0 comments
Open

Re-enable -Wshadow -Werror=shadow #48

JJL772 opened this issue Jul 7, 2023 · 0 comments
Milestone

Comments

@JJL772
Copy link
Member

JJL772 commented Jul 7, 2023

There's an edge case with the STATIC_ASSERT macro provided by EPICS when building with C++03 and earlier. Specifically when STATIC_ASSERT appears in global scope in an included file on the same line number as a function-scope STATIC_ASSERT in a different file.

PR: epics-base/epics-base#401

We'll probably never be able to enable -Werror=shadow in normal builds again, for compatibility reasons. But for BUILD_STRICT in CI, that's fair game after the aforementioned fix is merged.

@JJL772 JJL772 added this to the R1.8.0 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant