Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLACK_API_TOKEN in SlackError #552

Open
levenleven opened this issue Feb 28, 2025 · 0 comments
Open

SLACK_API_TOKEN in SlackError #552

levenleven opened this issue Feb 28, 2025 · 0 comments

Comments

@levenleven
Copy link

SlackError contains env.response, including request headers and SLACK_API_TOKEN

raise error_class.new(error_message, env.response)

This can be a foot gun as the token can be accidentally leaked by e.g. logging the error puts err.inspect.

Maybe we could auto redact auth header or even avoid storing whole response in the error instance and keep only e.g. body/status (but I guess this would be a breaking change)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant