Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream tutorials are missing the Vertex AI provider #13

Open
zimeg opened this issue Sep 28, 2024 · 0 comments
Open

Upstream tutorials are missing the Vertex AI provider #13

zimeg opened this issue Sep 28, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@zimeg
Copy link
Member

zimeg commented Sep 28, 2024

Summary

Great callout from @calvingiles with recent updates in #11:

I was reading the docs again and noticed that they replicate some of the instructions here - you might want to add some of the additions from the readme there too?

It is true that these docs and README don't match after the updates, though it'd be nice to keep these close in spirit IMO. Updates to the tutorial might add the Vertex AI provider and setup instruction 👀

We might also want to note some of this process in a MAINTAINERS_GUIDE since these updates aren't immediate when making changes to this sample IMO. I'm not sure if that page could be sourced from this sample to match updates to code and docs, but that might be more of a nice to have 🤔

@zimeg zimeg added the documentation Improvements or additions to documentation label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant