Skip to content

False positive for ComposeModifierReused #291

@ansman

Description

@ansman

Here is an example:

@Composable
fun Example(
    modifier: Modifier = Modifier,
    content: @Composable BoxScope.() -> Unit,
) {
    val context = LocalContext.current
    val currentContent by rememberUpdatedState(content)
    val currentModifier by rememberUpdatedState(modifier)
    val overlayView = remember {
        ComposeView(context).apply {
            setContent {
                Box(currentModifier.fillMaxSize(), content = currentContent)
            }
        }
    }
    DisposableEffect(overlayView) {
        onDispose {}
    }
}

I'm seeing a lint error on both the Box as well as the DisposableEffect saying that composable modifiers shouldn't be reused. Commenting out either removes the error.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions