Flavor capabilities: MySQL GR and more (vitessio#10451)

* Flavor capabilities: MySQL GR and more

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* unit tests

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Author: shlomi-noach

go/mysql/flavor.go

@@ -49,6 +49,8 @@ const (
 	InstantAddDropVirtualColumnFlavorCapability
 	InstantAddDropColumnFlavorCapability
 	InstantChangeColumnDefaultFlavorCapability
+	MySQLJSONFlavorCapability
+	MySQLUpgradeInServerFlavorCapability
 )
 
 const (

go/mysql/flavor_mysql.go

@@ -319,6 +319,8 @@ func (mysqlFlavor57) baseShowTablesWithSizes() string {
 // supportsCapability is part of the Flavor interface.
 func (mysqlFlavor57) supportsCapability(serverVersion string, capability FlavorCapability) (bool, error) {
 	switch capability {
+	case MySQLJSONFlavorCapability:
+		return true, nil
 	default:
 		return false, nil
 	}
@@ -343,6 +345,10 @@ func (mysqlFlavor80) supportsCapability(serverVersion string, capability FlavorC
 		return ServerVersionAtLeast(serverVersion, 8, 0, 17)
 	case FastDropTableFlavorCapability:
 		return ServerVersionAtLeast(serverVersion, 8, 0, 23)
+	case MySQLJSONFlavorCapability:
+		return true, nil
+	case MySQLUpgradeInServerFlavorCapability:
+		return ServerVersionAtLeast(serverVersion, 8, 0, 16)
 	default:
 		return false, nil
 	}

go/mysql/flavor_mysqlgr.go

@@ -241,6 +241,21 @@ func (mysqlGRFlavor) baseShowTablesWithSizes() string {
 // supportsCapability is part of the Flavor interface.
 func (mysqlGRFlavor) supportsCapability(serverVersion string, capability FlavorCapability) (bool, error) {
 	switch capability {
+	case InstantDDLFlavorCapability,
+		InstantAddLastColumnFlavorCapability,
+		InstantAddDropVirtualColumnFlavorCapability,
+		InstantChangeColumnDefaultFlavorCapability:
+		return ServerVersionAtLeast(serverVersion, 8, 0, 0)
+	case InstantAddDropColumnFlavorCapability:
+		return ServerVersionAtLeast(serverVersion, 8, 0, 29)
+	case TransactionalGtidExecutedFlavorCapability:
+		return ServerVersionAtLeast(serverVersion, 8, 0, 17)
+	case FastDropTableFlavorCapability:
+		return ServerVersionAtLeast(serverVersion, 8, 0, 23)
+	case MySQLJSONFlavorCapability:
+		return ServerVersionAtLeast(serverVersion, 5, 7, 0)
+	case MySQLUpgradeInServerFlavorCapability:
+		return ServerVersionAtLeast(serverVersion, 8, 0, 16)
 	default:
 		return false, nil
 	}

go/mysql/flavor_test.go

@@ -125,6 +125,16 @@ func TestGetFlavor(t *testing.T) {
 			capability: TransactionalGtidExecutedFlavorCapability,
 			isCapable:  false,
 		},
+		{
+			version:    "5.6.7",
+			capability: MySQLJSONFlavorCapability,
+			isCapable:  false,
+		},
+		{
+			version:    "5.7.29",
+			capability: MySQLJSONFlavorCapability,
+			isCapable:  true,
+		},
 	}
 	for _, tc := range testcases {
 		name := fmt.Sprintf("%s %v", tc.version, tc.capability)