@@ -152,7 +152,7 @@ func (be *MySQLShellBackupEngine) ExecuteBackup(ctx context.Context, params Back
152
152
}
153
153
lockAcquired := time .Now () // we will report how long we hold the lock for
154
154
155
- posBeforeBackup , err := params .Mysqld .PrimaryPosition (ctx )
155
+ posBeforeBackup , err := params .Mysqld .PrimaryPosition ()
156
156
if err != nil {
157
157
return BackupUnusable , vterrors .Wrap (err , "failed to fetch position" )
158
158
}
@@ -255,20 +255,20 @@ func (be *MySQLShellBackupEngine) ExecuteRestore(ctx context.Context, params Res
255
255
}
256
256
257
257
// make sure semi-sync is disabled, otherwise we will wait forever for acknowledgements
258
- err = params .Mysqld .SetSemiSyncEnabled (ctx , false , false )
258
+ err = params .Mysqld .SetSemiSyncEnabled (false , false )
259
259
if err != nil {
260
260
return nil , vterrors .Wrap (err , "disable semi-sync failed" )
261
261
}
262
262
263
263
params .Logger .Infof ("restoring on an existing tablet, so dropping database %q" , params .DbName )
264
264
265
- readonly , err := params .Mysqld .IsSuperReadOnly (ctx )
265
+ readonly , err := params .Mysqld .IsSuperReadOnly ()
266
266
if err != nil {
267
267
return nil , vterrors .Wrap (err , fmt .Sprintf ("checking if mysqld has super_read_only=enable: %v" , err ))
268
268
}
269
269
270
270
if readonly {
271
- resetFunc , err := params .Mysqld .SetSuperReadOnly (ctx , false )
271
+ resetFunc , err := params .Mysqld .SetSuperReadOnly (false )
272
272
if err != nil {
273
273
return nil , vterrors .Wrap (err , fmt .Sprintf ("unable to disable super-read-only: %v" , err ))
274
274
}
@@ -466,15 +466,15 @@ func (be *MySQLShellBackupEngine) restorePreCheck(ctx context.Context, params Re
466
466
}
467
467
468
468
func (be * MySQLShellBackupEngine ) handleSuperReadOnly (ctx context.Context , params RestoreParams ) (func (), error ) {
469
- readonly , err := params .Mysqld .IsSuperReadOnly (ctx )
469
+ readonly , err := params .Mysqld .IsSuperReadOnly ()
470
470
if err != nil {
471
471
return nil , vterrors .Wrap (err , fmt .Sprintf ("checking if mysqld has super_read_only=enable: %v" , err ))
472
472
}
473
473
474
474
params .Logger .Infof ("Is Super Read Only: %v" , readonly )
475
475
476
476
if readonly {
477
- resetFunc , err := params .Mysqld .SetSuperReadOnly (ctx , false )
477
+ resetFunc , err := params .Mysqld .SetSuperReadOnly (false )
478
478
if err != nil {
479
479
return nil , vterrors .Wrap (err , fmt .Sprintf ("unable to disable super-read-only: %v" , err ))
480
480
}
0 commit comments