Improve method order and fix phpstan issue

Author: markusweigelt

Classes/Validation/DomDocumentUrlExistenceValidator.php

@@ -50,6 +50,34 @@ public function __construct(array $configuration = [])
         $this->excludeHosts = isset($configuration["excludeHosts"]) ? explode(",", $configuration["excludeHosts"]) : [];
     }
 
+
+
+    protected function isValid($value): void
+    {
+        foreach ($this->getDocumentUrls($value) as $url) {
+            if (!$this->isExcluded($url) && !$this->urlExists($url)) {
+                $this->addError('URL "' . $url . '" could not be found.', 1737384167);
+            }
+        }
+    }
+
+    /**
+     * Retrieve all URLs of the document, except for the URLs of the file groups, where only one URL is returned per file group and host.
+     *
+     * @param DOMDocument $document The document
+     * @return array The array of URLs
+     */
+    protected function getDocumentUrls(DOMDocument $document): array
+    {
+        $tempDocument = clone $document; // do not modify original document
+        $urls = $this->getFileUrlAndRemoveFileGroups($tempDocument);
+
+        // get the urls of document without file group nodes
+        preg_match_all('/' . ValidationHelper::URL_REGEX . '/i', $tempDocument->saveXML(), $matches);
+        $urls += $matches[0] ?? [];
+        return array_unique($urls);
+    }
+
     /**
      * Get the representative file urls and remove file groups to prevent rechecking.
      *
@@ -67,6 +95,7 @@ protected function getFileUrlAndRemoveFileGroups(DOMDocument $document): array
         foreach ($fileGroups as $fileGroup) {
             $fLocats = $xpath->query('mets:file/mets:FLocat', $fileGroup);
             foreach ($fLocats as $fLocat) {
+                // @phpstan-ignore-next-line
                 $url = $fLocat->getAttribute("xlink:href");
                 $host = parse_url($url, PHP_URL_HOST);
                 if (!in_array($host, $hosts)) {
@@ -80,32 +109,6 @@ protected function getFileUrlAndRemoveFileGroups(DOMDocument $document): array
         return $urls;
     }
 
-    protected function isValid($value): void
-    {
-        foreach ($this->getDocumentUrls($value) as $url) {
-            if (!$this->isExcluded($url) && !$this->urlExists($url)) {
-                $this->addError('URL "' . $url . '" could not be found.', 1737384167);
-            }
-        }
-    }
-
-    /**
-     * Retrieve all URLs of the document, except for the URLs of the file groups, where only one URL is returned per file group and host.
-     *
-     * @param DOMDocument $document The document
-     * @return array The array of URLs
-     */
-    protected function getDocumentUrls(DOMDocument $document): array
-    {
-        $tempDocument = clone $document; // do not modify original document
-        $urls = $this->getFileUrlAndRemoveFileGroups($tempDocument);
-
-        // get the urls of document without file group nodes
-        preg_match_all('/' . ValidationHelper::URL_REGEX . '/i', $tempDocument->saveXML(), $matches);
-        $urls += $matches[0] ?? [];
-        return array_unique($urls);
-    }
-
     private function urlExists($url): bool
     {
         $headers = @get_headers($url);