Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Config instance builder #1021

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Config instance builder #1021

wants to merge 1 commit into from

Conversation

dmlloyd
Copy link
Contributor

@dmlloyd dmlloyd commented Oct 3, 2023 •
edited
Loading

Update: there is now a basic (but incomplete) implementation.

This is a first draft of the builder API for constructing configuration instances. No implementation is included yet; this is just for API review.

Fixes #1001.

@dmlloyd dmlloyd requested a review from radcortez October 3, 2023 19:51
radcortez
radcortez previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@radcortez radcortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dmlloyd dmlloyd changed the title [WIP] API for config instance builder [WIP] Config instance builder Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radcortez radcortez radcortez left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API for using mapped configurations in a standalone way
2 participants
@dmlloyd @radcortez