Execute the timeout to release the lock correctly

[liuzhaozhao]

private Uni<Void> test1() {
    return Uni.createFrom().voidItem()
        .flatMap(r -> getLock()
                .flatMap(lock -> doSomethingUni())
                .eventually(this::releaseLock)
        ).ifNoItem().after(Duration.ofSeconds(60)).fail();
}
private Uni<String> getLock() {
    return Uni.createFrom().item("test-lock");
}
private Uni<Void> doSomethingUni() {
    return Uni.createFrom().voidItem();
}
private void releaseLock() {
}

Here is a code example that simplifies the usage scenario,
How to correctly release the lock after the execution of getLock() and before the execution of releaseLock() has timed out?
Can you help me to write a correct sample code?

[jponge]

Since releaseLock is not a reactive method you might use a onItem().invoke(() -> releaseLock()) after some call.

[liuzhaozhao]

but doSomethingUni() method is a reactive method，will cause a timeout，and releaseLock() method must be executed after doSomethingUni() methods

[liuzhaozhao]

I did a test：

@Test
public void testUniLockTimeout() throws InterruptedException {
    println("start");
    Uni.createFrom().voidItem().flatMap(r ->
                getLock()
                    .flatMap(lock -> doSomethingUni(7))
                    .eventually(this::releaseLock)
            ).ifNoItem().after(Duration.ofSeconds(3)).fail()
            .onFailure().invoke(Throwable::printStackTrace)
            .onFailure().recoverWithNull()
            .invoke(v -> println("done")).await().indefinitely();
    println("stopping");
    Thread.sleep(10_000);
    println("stopped");
}
private Uni<String> getLock() {
    return Uni.createFrom().item("test-lock");
}
private Uni<Void> doSomethingUni(long waitSecond) {
    return Uni.createFrom().voidItem().onItem().delayIt().by(Duration.ofSeconds(waitSecond));
}
private void releaseLock() {
    println("releaseLock");
}

public static void println(String msg) {
    String dataStr = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS").format(new Date());
    System.out.println(String.format("%s[INFO]-[%s]-[%s]: %s", dataStr, Thread.currentThread().getName(), UnitTest.class.getName(), msg));
}

1. quarkus 2.13.7（mutiny 1.7.0）：The result is releaseLock() not executed.

2023-04-25 22:51:09.487[INFO]-[main]-[cn.ecpark.service.iov.analysis.UnitTest]: start1
io.smallrye.mutiny.TimeoutException
	at io.smallrye.mutiny.operators.uni.UniFailOnTimeout$UniFailOnTimeoutProcessor.doTimeout(UniFailOnTimeout.java:102)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
2023-04-25 22:51:12.686[INFO]-[pool-1-thread-1]-[cn.ecpark.service.iov.analysis.UnitTest]: done
2023-04-25 22:51:12.687[INFO]-[main]-[cn.ecpark.service.iov.analysis.UnitTest]: stopping
2023-04-25 22:51:22.694[INFO]-[main]-[cn.ecpark.service.iov.analysis.UnitTest]: stopped

2. quarkus 2.16.6（mutiny 1.9.0）：The result is releaseLock() executed.

2023-04-25 22:57:51.723[INFO]-[main]-[cn.ecpark.service.iov.analysis.UnitTest]: start
2023-04-25 22:57:54.973[INFO]-[pool-1-thread-1]-[cn.ecpark.service.iov.analysis.UnitTest]: releaseLock
io.smallrye.mutiny.TimeoutException
	at io.smallrye.mutiny.operators.uni.UniFailOnTimeout$UniFailOnTimeoutProcessor.doTimeout(UniFailOnTimeout.java:102)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
2023-04-25 22:57:54.975[INFO]-[pool-1-thread-1]-[cn.ecpark.service.iov.analysis.UnitTest]: done
2023-04-25 22:57:54.976[INFO]-[main]-[cn.ecpark.service.iov.analysis.UnitTest]: stopping
2023-04-25 22:58:04.989[INFO]-[main]-[cn.ecpark.service.iov.analysis.UnitTest]: stopped

[jponge]

We recently changed the implementation of Uni.eventually to handle cancellation. It is now equivalent to onTermination().invoke(...). What you see in 1.9.0 is the expected behavior.