Uni combine ignores singular uni failure mechanism

[manofthepeace]

Hi. I am trying mutiny, via quarkus (2.4.2) and I have difficulty with properly handling failures when combining Unis, following this guide. https://smallrye.io/smallrye-mutiny/guides/combining-items.

I have a list of upstreams, i'd like to have retry and failure handling on each individual upstream/uni (i.e. failure to return an empty set/log, retry, etc).

When using the uni for a single upstream I can do the following which works. When subscribed to, if the upstream fails, the uni is retried

Uni<Set<Event>> uni = eventService.getEvents();
return uni.onFailure().retry().withBackOff(Duration.ofSeconds(1)).withJitter(0.2).atMost(3);

But when combining the above uni like this;

List<Uni<Set<Event>>> unis = new ArrayList<>();
Uni<Set<Event>> uni = eventService.getEvents(); // I have multiple of those
uni.onFailure().retry().withBackOff(Duration.ofSeconds(1)).withJitter(0.2).atMost(3);
unis.add(uni);

return Uni.combine().all().unis(unis).combinedWith(responses -> {
            Set<Event> events = new HashSet<>();
            for (Object response : responses) {
                events.addAll((Set<Event>) response);
            }
            return events;
        });

The failures per uni are totally ignored. If I make my upstream fail I get the failure right away, from the combined uni. So it would lead to the following questions;

1. Is there a way to not make everything fail if one upstream fails. I still one the items of what worked.
2. If there a way to make the combined uni respect all the singular uni onX events retry and/or invoke etc. Ultimately I'd like the failing unis the be retried.

Help would be greatly appreciated.

Thanks you!

[manofthepeace]

Sorry that was a dumb mistake.
missed the uni = for setting the onFailure

It works properly now.

[jponge]

Great!