From a1b7f6fa1a31c0248eb94dd91848a43cfc3f255a Mon Sep 17 00:00:00 2001 From: Cuichen Li Date: Mon, 26 Feb 2024 11:45:01 +0800 Subject: [PATCH] add missing log --- .../io/smallrye/reactive/messaging/aws/sqs/SqsConfig.java | 2 +- .../reactive/messaging/aws/sqs/i18n/AwsSqsLogging.java | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/smallrye-reactive-messaging-aws-sqs/src/main/java/io/smallrye/reactive/messaging/aws/sqs/SqsConfig.java b/smallrye-reactive-messaging-aws-sqs/src/main/java/io/smallrye/reactive/messaging/aws/sqs/SqsConfig.java index 74a1b5c95d..bfb94bec9e 100644 --- a/smallrye-reactive-messaging-aws-sqs/src/main/java/io/smallrye/reactive/messaging/aws/sqs/SqsConfig.java +++ b/smallrye-reactive-messaging-aws-sqs/src/main/java/io/smallrye/reactive/messaging/aws/sqs/SqsConfig.java @@ -40,7 +40,7 @@ public Optional getRegion() { try { return Optional.of(Region.of(result.get())); } catch (IllegalArgumentException e) { - // TODO: LOG + log.failedToParseAwsRegion(result.get(), e.getMessage()); return Optional.empty(); } } diff --git a/smallrye-reactive-messaging-aws-sqs/src/main/java/io/smallrye/reactive/messaging/aws/sqs/i18n/AwsSqsLogging.java b/smallrye-reactive-messaging-aws-sqs/src/main/java/io/smallrye/reactive/messaging/aws/sqs/i18n/AwsSqsLogging.java index b6637be257..fcb0b9e845 100644 --- a/smallrye-reactive-messaging-aws-sqs/src/main/java/io/smallrye/reactive/messaging/aws/sqs/i18n/AwsSqsLogging.java +++ b/smallrye-reactive-messaging-aws-sqs/src/main/java/io/smallrye/reactive/messaging/aws/sqs/i18n/AwsSqsLogging.java @@ -30,4 +30,8 @@ public interface AwsSqsLogging extends BasicLogger { @LogMessage(level = Level.WARN) @Message(id = 19303, value = "Failed to load the AWS credential loader, use the default credential provider chain %s") void failedToLoadAwsCredentialLoader(String message); + + @LogMessage(level = Level.WARN) + @Message(id = 19304, value = "Failed to parse provided AWS Region, will apply the AWS SDK built-in logic to detect region. %s, %s") + void failedToParseAwsRegion(String region, String message); }