Lesson 8 - Error: VM Exception while processing transaction: reverted with reason string 'You need to spend more ETH!'

[M1708]

After adding the hardhat localhost to metamask and importing account from hardhat, setting eth_amount="0.1", when I run the 'fund' function in the browser I get this error on my console.

Error: VM Exception while processing transaction: reverted with reason string 'You need to spend more ETH!'

where as I don't see any error for Patrick on his console. I tried with different etc_amount values, but still getting the same error.

Any pointers on what am I doing wrong?

[alymurtazamemon]

@M1708 This error means you are not sending enough ethers (including gas cost).

Is it a test or something else? Show the code and particularly the code snippet where this error is coming.

[MetaElango]

@ali-thegilfoyle I have 10000 ETH in my wallet

[alymurtazamemon]

@M1708 Which testnet is that Rinkeby?

[MetaElango]

no it is local hardhat node @ali-thegilfoyle

[MetaElango]

now I made few more changes to my code. I declared the amount directly inside fund() function and added an console.log() in PriceConverter.sol

FundMe.sol

function fund() public payable {
        console.log("message value", msg.value);
        uint256 amount = 3;
        console.log(amount.getConversionRate(s_priceFeed), MINIMUM_USD);
        
        require(msg.value.getConversionRate(s_priceFeed) >= MINIMUM_USD, "You need to spend more ETH!");
        // require(PriceConverter.getConversionRate(msg.value) >= MINIMUM_USD, "You need to spend more ETH!");
        s_addressToAmountFunded[msg.sender] += msg.value;
        s_funders.push(msg.sender);
}

function getConversionRate(
        uint256 ethAmount,
        AggregatorV3Interface priceFeed
    ) internal view returns (uint256) {
        console.log("Eth amount", ethAmount);
        uint256 ethPrice = getPrice(priceFeed);
        uint256 ethAmountInUsd = (ethPrice * ethAmount) / 1000000000000000000;
        // the actual ETH/USD conversion rate, after adjusting the extra 0s.
        return ethAmountInUsd;
 }

my output

eth_call
  Contract call:       <UnrecognizedContract>
  From:                0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
  To:                  0xe7f1725e7734ce288f8367e1bb143e90bb3f0512

  console.log:
    message value 0
    Eth amount 3
    6000 50000000000000000000

even after sending 3 eth only getting 6000 as converted amount. What am I doing wrong here @ali-thegilfoyle

[Pikkuherkko]

I have same problem lol

[cckoyou]

same problem :(
I printed out msg.value in the contract fundMe.fund() with console.log, it seems the msg.value is always 0 no matter how much ETH you send in matemask transaction
I'm stucked:(

[alliums-p]

Going through the same problem!

        console.log("ETH sent: ", msg.value);
        if(msg.value.getConversionRate(priceFeed) < MINIMUM_USD) revert FundMe__NotEnoughETH();

I get the value of "ETH sent: 0" no matter what number of ETH I send to the fund() function.

Another thing I noticed was; Even if I changed my account (say Acc-B) and did transfer funds from Acc-B the ETH would be deducted from it but the deployer contract does the execution of the code. There's a screenshot of the transaction below:

The transaction was done by 0x.....79C8 account but the transaction details show it was done by the deployer account (0x......2266).

Can't figure out the problem in this code. Any help would be greatly appreciated! @PatrickAlphaC
Thank you :)

[alymurtazamemon]

@alliums-p Why do you have added less than sign (<)?

[alliums-p]

Cause it's supposed to be the condition. Revert the transaction if the price of ETH sent is "less than" MinimumUSD.

[alymurtazamemon]

@alliums-p Yes, sorry My bad!

[israel31]

Hi, please kindy check the MinimumUsd to see if the eth you are sending is up to it. The code isn't wrong, you just need to increase the ETH up to maybe 50 and above

[M1708]

I don't know what I did but it is working for me now.
Few things I noticed, if restarting your hardhat server for whatever reason, make sure to restart GoLive server too and 'reset account' in metamask.
I will paste my code below for reference

fund()/fallback/receive functions from FundMe.sol

  /// @notice Funds our contract based on the ETH/USD price
    function fund() public payable {
        console.log("message value", msg.value);
        uint256 conv_value = msg.value.getConversionRate(s_priceFeed);
        console.log("Converted Value: ", conv_value);

        require(
            msg.value.getConversionRate(s_priceFeed) >= MINIMUM_USD,
            "You need to spend more ETH!"
        );
        //require(PriceConverter.getConversionRate(msg.value) >= MINIMUM_USD, "You need to spend more ETH!");
        s_addressToAmountFunded[msg.sender] += msg.value;
        s_funders.push(msg.sender);
    }

   fallback() external payable {
          //console.log("In Fallback", msg.value);
          //fund();
      }


    receive() external payable {
        //console.log("In Receive", msg.value);
        //fund();
    }

index.js

import { ethers } from "./ethers-5.6.esm.min.js";
import { abi, contractAddress } from "./constants.js";

const connectButton = document.getElementById("connectButton");
const fundButton = document.getElementById("fundButton");
const balanceButton = document.getElementById("balanceButton");
const withdrawButton = document.getElementById("withdrawButton");

connectButton.onclick = connect;
fundButton.onclick = fund;
balanceButton.onclick = getBalance;
withdrawButton.onclick = withdraw;

async function connect() {
  if (typeof window.ethereum !== "undefined") {
    await window.ethereum.request({ method: "eth_requestAccounts" });
    connectButton.innerHTML = "Connected!";
  } else {
    fundButton.innerHTML = "Please install metamask!";
  }
}

async function getBalance() {
  if (typeof window.ethereum !== "undefined") {
    const provider = new ethers.providers.Web3Provider(window.ethereum);
    try {
      const balance = await provider.getBalance(contractAddress);
      console.log(ethers.utils.formatEther(balance));
    } catch (error) {
      console.log(error);
    }
  } else {
    balanceButton.innerHTML = "Please install MetaMask";
  }
}

async function withdraw() {
  console.log(`Withdrawing...`);
  if (typeof window.ethereum != "undefined") {
    const provider = new ethers.providers.Web3Provider(window.ethereum);
    const signer = provider.getSigner();
    const contract = new ethers.Contract(contractAddress, abi, signer);

    try {
      const transactionResponse = await contract.withdraw();
      await listenForTransactionMine(transactionResponse, provider);
    } catch (error) {
      console.log(error);
    }
  }
}

async function fund() {
  const ethAmount = document.getElementById("ethAmount").value;
  console.log(`Funding with ${ethAmount}...`);
  if (typeof window.ethereum !== "undefined") {
    const provider = new ethers.providers.Web3Provider(window.ethereum);
    const signer = provider.getSigner();
    const contract = new ethers.Contract(contractAddress, abi, signer);
    try {
      const transactionResponse = await contract.fund({
        value: ethers.utils.parseEther(ethAmount),
      });
      await listenForTransactionMine(transactionResponse, provider);
    } catch (error) {
      console.log(error);
    }
  } else {
    fundButton.innerHTML = "Please install MetaMask";
  }
}

function listenForTransactionMine(transactionResponse, provider) {
  console.log(`Mining ${transactionResponse.hash}...`);
  return new Promise((resolve, reject) => {
    provider.once(transactionResponse.hash, (transactionReceipt) => {
      console.log(
        `Completed with ${transactionReceipt.confirnations} confirmations`
      );
      resolve();
    });
  });
}

Console output screenshot

[letallan]

Worked for me, thanks! But still there is a weird node's output with many eth_call errors

eth_call
  Contract call:       FundMe#<unrecognized-selector>
  From:                0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
  To:                  0xe7f1725e7734ce288f8367e1bb143e90bb3f0512

  Error: VM Exception while processing transaction: reverted with reason string 'You need to spend more ETH!'

[alliums-p]

Hi!
I don't exactly know why this is happening. But the transaction has passed. The thing you have to do is to increase the overall gas fee/price/limit of the transaction from metamask. Your transaction will have successfully passed.

You might still see a bunch of failed transactions in the node console. But ignore it all, if you scroll through it you will find the successful transaction somewhere there it's just being overwhelmed by random failed transactions that you did not even initiate. Weird.

Good luck to y'all! Hope this solves your problem. :)

[prakhar9015]

hey guys, i think i got the SOLUTION ... here the issue is in the fund() function . , where we're passing the ethAmount value as a string to the value parameter, but we are not converting it to the expected format.

To fix this use the parseEther() function from the ethers.utils library to convert the ethAmount string to the expected format

look at my code here 👇

async function fund() {
    const ethAmount = "0.1"
    console.log(`Funding with ${ethAmount}`)

    if (typeof window.ethereum !== "undefined") {
        const provider = new ethers.providers.Web3Provider(window.ethereum)
        const signer = provider.getSigner()
        console.log(signer)

        const contract = new ethers.Contract(contractAddress, abi, signer)
        try {
            const transactionResponse = await contract.fund({
                value: ethers.utils.parseEther(ethAmount),   //  <--    👈 fix here
            })
        } catch (error) {
            console.log(error)
        }
    }
}

I hope this will fix the bug. share this if it helped you 😊
One thing to pay attention is that : even if the transaction will pass, and to verify that check the metamask and the account balance will be deducted by however ETH you're sending, but it will not show the same confirmation in vscode's node , so don't get discouraged, it will somehow find its way...

[MahzyarSaadat]

Hi ,
I increase the gas fee price from metamask , the transaction successfully passed.
but i see a bunch of errors in node console.

did anyone solve the node console error problem???

[stshelton]

Im still running into this issue. whenever I run fund from the webpage I get the error below in terminal and error within console also found below. Metamask doesn't show transactions either. I try printing the value sent in for fund me but its always 0. And calling fund brings up metamask but also has local node printing error found below multiple times.

Terminal

eth_call
  Contract call:       FundMe#<unrecognized-selector>
  From:                0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
  To:                  0xe7f1725e7734ce288f8367e1bb143e90bb3f0512

  console.log:
    0
    50000000000000000000

  Error: VM Exception while processing transaction: reverted with reason string 'Didnt send enough'
      at FundMe.fund (contracts/FundMe.sol:114)
      at FundMe.<fallback> (contracts/FundMe.sol:88)
      at HardhatNode.runCall (/Users/spencershelton/Documents/CodeCampSmartContract/hardhat-fund-me-fcc/node_modules/hardhat/src/internal/hardhat-network/provider/node.ts:616:20)
      at EthModule._callAction (/Users/spencershelton/Documents/CodeCampSmartContract/hardhat-fund-me-fcc/node_modules/hardhat/src/internal/hardhat-network/provider/modules/eth.ts:354:9)
      at HardhatNetworkProvider._sendWithLogging (/Users/spencershelton/Documents/CodeCampSmartContract/hardhat-fund-me-fcc/node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:139:22)
      at HardhatNetworkProvider.request (/Users/spencershelton/Documents/CodeCampSmartContract/hardhat-fund-me-fcc/node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:116:18)
      at JsonRpcHandler._handleRequest (/Users/spencershelton/Documents/CodeCampSmartContract/hardhat-fund-me-fcc/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:188:20)
      at JsonRpcHandler._handleSingleRequest (/Users/spencershelton/Documents/CodeCampSmartContract/hardhat-fund-me-fcc/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:167:17)
      at Server.JsonRpcHandler.handleHttp (/Users/spencershelton/Documents/CodeCampSmartContract/hardhat-fund-me-fcc/node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:52:21)

contract

contract FundMe {
    //Type declarations
    //how to attach a library to a type
    using PriceConverter for uint256;
    uint256 public constant MINIMUM_USD = 50 * 1e18; // 1 * 10^18

    address private immutable i_owner;
    address[] private s_funders;
    mapping(address => uint256) private s_addressToAmountFunded;

    AggregatorV3Interface private s_priceFeed;

    //Modifers
    modifier onlyOwner() {
        if (msg.sender != i_owner) {
            revert FundMe__NotOwner();
        }
        _;
    }


    constructor(address priceFeedAddress) {
        s_priceFeed = AggregatorV3Interface(priceFeedAddress);
        i_owner = msg.sender;
    }

    receive() external payable {
        fund();
    }

    fallback() external payable {
        fund();
    }

    //add payable if you want to be able to send money to contract
    /**
     *  @notice this function funds this contract
     *  @dev This implements price feeds as our library
     */
    function fund() public payable {

//this prints zero even 
        console.log(msg.value.getConversionRate(s_priceFeed));
        console.log(MINIMUM_USD);
        require(
            msg.value.getConversionRate(s_priceFeed) >= MINIMUM_USD,
            "Didnt send enough"
        );
        s_funders.push(msg.sender);
        s_addressToAmountFunded[msg.sender] = msg.value;
    }

 
    function withdraw() public onlyOwner {
        for (
            uint256 funderIndex = 0;
            funderIndex < s_funders.length;
            funderIndex++
        ) {
            //code
            address funder = s_funders[funderIndex];
            s_addressToAmountFunded[funder] = 0;
        }
        //reset array parathesis how many to start array with
        s_funders = new address[](0);
        (bool callSuccess, ) = payable(msg.sender).call{
            value: address(this).balance
        }("");
        require(callSuccess, "Call failed");
    }

    function cheaperWithdraw() public payable onlyOwner {
    
        address[] memory m_funders = s_funders;
   
        for (
            uint256 funderIndex = 0;
            funderIndex < m_funders.length;
            funderIndex++
        ) {
            address funder = m_funders[funderIndex];
            s_addressToAmountFunded[funder] = 0;
        }

        s_funders = new address[](0);
        (bool callSuccess, ) = payable(msg.sender).call{
            value: address(this).balance
        }("");
        require(callSuccess, "Call failed");
    }

    function getOwner() public view returns (address) {
        return i_owner;
    }

    function getFunder(uint256 index) public view returns (address) {
        return s_funders[index];
    }

    function getAddressToAmountFunded(address funder)
        public
        view
        returns (uint256)
    {
        return s_addressToAmountFunded[funder];
    }

    function getPriceFeed() public view returns (AggregatorV3Interface) {
        return s_priceFeed;
    }
}

im receiving this error in console of webpage

index.js

//import
//in nodejs uses require to add frameworks or other files
//front end javascript uses import
import { ethers } from "./ethers-5.6.esm.min.js"
import { abi, contractAddress } from "./constants.js"

const connectButton = document.getElementById("connectButton")
const fundButton = document.getElementById("fundButton")
connectButton.onclick = connect
fundButton.onclick = fund

async function connect() {
    if (typeof window.ethereum !== "undefined") {
        console.log("I see a metamask!")
        try {
            await window.ethereum.request({ method: "eth_requestAccounts" })
        } catch (error) {
            console.log(error)
        }
        console.log("Connected wallet")
        connectButton.innerHTML = "Connected"
        const accounts = await ethereum.request({ method: "eth_accounts" })
        console.log(accounts)
    } else {
        console.log("no metamask!")
        connectButton.innerHTML = "Please install metamask"
    }
}

//fund function
async function fund() {
    const ethAmount = "1"
    console.log(`Funding with ${ethAmount}`)
    if (typeof window.ethereum !== "undefined") {
        //provider / connection to the block chain
        //signer / wallet / someone with gas
        // contract that we are interacting with
        //^ ABI & Address
        //provider

        //provider would be metamask, meta mask has connection to block chain to
        const provider = new ethers.providers.Web3Provider(window.ethereum)
        //gets the current wallet that is connected
        const signer = provider.getSigner()
        console.log(signer)
        //now time to get contract, we will need to know address and abi
        const contract = new ethers.Contract(contractAddress, abi, signer)
        const transactionResponse = await contract.fund({
            value: ethers.utils.parseEther(ethAmount),
        })
    }
}

[stshelton]

Fix for error found within the console can be found here #539

[stshelton]

#546 (comment) is correct once I increased gas fee I was able to see the terminal successfully print the contract call FundMe with a success. But all around that output are eth_call that failed so it was hard for me to find. Do we have any idea why eth_call seems to get called a tone? When i call fund within local site and metamask pops up is the contract called yet? Because if so I think the receive or fallback functions are being called and that's why we are seeing the failed eth_call.

[stshelton]

So I took out my receive and fallback functions and I'm no longer getting failed eth-calls with "didnt send enough" as error. This is because my receive and fallback functions were calling fund me yet there was nothing to fund it with so it would error with "didnt send enough". Once I removed those functions I now receive eth_call errors because contract was called without a reason string (and no receive or fallback functions were implemented). Although it seems contract is still called a tone before and after accepting metamasks transaction. My question is why is the contract called before accepting transaction on metamask??

[lightrao]

I meet the same problem, mybe hardhat node network have some problem, try Ganache.

[kiraliwhite]

Hello~
I also had the same problem. I've also checked the require condition and made sure that the minimum donation amount is met.
So I made some attempts.

I observed that this error happens once the funding button is pressed, even without pressing the transaction confirm button on MetaMask.
https://user-images.githubusercontent.com/104891984/196585353-a9bbf118-a437-4da7-a158-bb937932f57b.mov

That is to say, I have not yet confirmed my transaction, the condition of require has been triggered. This is interesting.

So I temporarily removed the require of the Fund function.

There are no more error messages in the console of yarn hardhat node.

[DylanJinx]

Yes, remove this code first: require(msg.value.getConversionRate(s_priceFeed)>=MINIMUM_USD, "you need spend more ETH" );

[arkamrani]

Hi guys, I have a method to transfer money, but when it gets called "msg.value" is always 0, and Metamask doesn't popup for tx confirmation:

function transfer(
        address payable _seller,
        uint256 _totalPrice
    ) external payable 
{
_seller.transfer(_totalPrice)
}

[alymurtazamemon]

@alirezakamrani Make sure the localhost settings, RPC_URL you should copy from hardhat node and chainId should be 31337.

[arkamrani]

Thank you for your response. I can interact with metamask on localhost (like 'getApprovall' and singin transactions), but when it comes to transferring eth, metamask doesn't pop up.
When I change the code to this problem will solve, and Metamask will open for approving the gas fee:

function transfer( address payable _seller, uint256 _totalPrice ) external payable { _seller.transfer(msg.value) }

I think there is a bug or misconfiguration or incompatibility in libraries

[HarshulGaba]

I figured it out, so the thing is in the condition all the values are in 'Wei' even the minimum USD amount is hard coded into the contract as wei. But when you go to metamask it parses the value in 'ETH' not in 'Wei'. So basically on your backend hardhat node the value is 5000 wei that it detects but on your frontend metamask the value is in ETH.

If you change the MinimumUSD in FundMe.sol to 50 instead of 50*10**18 it'll work.

[DylanJinx]

I think you're right.

[badukwei]

Agree with the solution

[raazymuhd1]

After adding the hardhat localhost to metamask and importing account from hardhat, setting eth_amount="0.1", when I run the 'fund' function in the browser I get this error on my console.

Error: VM Exception while processing transaction: reverted with reason string 'You need to spend more ETH!'

where as I don't see any error for Patrick on his console. I tried with different etc_amount values, but still getting the same error.

Any pointers on what am I doing wrong?

this is worked for me really well

const fund = async() => {
    const ethAmount = "2" 

    if(typeof window.ethereum !== undefined) {
        try {
            const provider = new ethers.providers.Web3Provider(window.ethereum);
            const signer = provider.getSigner();
            const FundMe = new ethers.Contract(contractAddress, abi, signer)
    
            await FundMe.fund({value: ethers.utils.parseEther(ethAmount)})
            
        } catch (error) {
            console.log(error)
        }
    }
}

fundBtn.addEventListener("click", fund);

and change this line on FundMe.sol

 uint256 public constant MINIMUM_USD = 1;

[GovindHQ]

Wow it worked! Can you explain why MINIMUM_USD should be one? (I was using the hardhat localhost for testing).

[sikehish]

The error still persists. i tried everything.

script.js(Lesson 8)

// fund function
const fund = async (ethAmount) => {
  if (window.ethereum) {
    const provider = new ethers.providers.Web3Provider(window.ethereum);
    const signer = provider.getSigner();
    const contract = new ethers.Contract(contractAddress, abi, signer);
    try {
      const txRes = await contract.fund({
        value: ethers.utils.parseEther("2"),
      });
    } catch (err) {
      console.log(err);
    }
  }
};

fundMe.sol

uint256 public constant MINIMUM_USD = 1;

    function fund() public payable {
        require(
            msg.value.getConversionRate(s_priceFeed) >= MINIMUM_USD,
            "You need to spend more ETH!"
        );
        s_addressToAmountFunded[msg.sender] += msg.value;
        s_funders.push(msg.sender);
    }

Error:

Error: VM Exception while processing transaction: reverted with reason string 'You need to spend more ETH!'
at FundMe.fund (contracts/FundMe.sol:53)
at FundMe. (contracts/FundMe.sol:126)

As @kiraliwhite rightly pointed out, error happens once the funding button is pressed, even without pressing the transaction confirm button on MetaMask.

Do I ignore the error and continue? Ive spent quite some time debugging this, but to my dismay, I haven't really got the solution. The transactions however are taking place

[amine08]

Hi everyone i started learning blockchain recently and i face the same error in nather project so
i think that you need to wait for the operation (await ) Good luck

[akyouts]

I am also having the same issue can some solve this .