Has anyone used VRF V2.5?

[nabeel-ahmed004]

Hi! Currently we can only make VRF V2.5 subscriptions which are not suitable for Patrick's original code. So is there anyone who has completed this section using V2.5 and has a repo? I am stuck on this section for two days so I will be very very thankful to you.

[HarigovindM-G]

yeap i got you mate , i migrated my entire stuff to VRF 2.5 lol , i will just put my repo link , hope it will help ya , i found my way through it using the docs

https://github.com/HarigovindM-G/Lucky-Node-Hardhat

[M-D-Nadeem]

Hii @HarigovindM-G Yes i resolved my previous error,
But now the WinnerEnding balance is not getting equal to WinnerStarting balance +entrenceFee ,
Moreover WinnerEnding balance is decreasing rather than increasing, i think the money is not getting transferred to winner account

My unit tests are passing
Please help me to resolve this issue
And thanks you for your help in migrating from v2 to v2_5 it would be not been possible without your help

I am sharing my errors as well as my git hub ,please check once
GitHub repo link -> https://github.com/M-D-Nadeem/hardhat-lottery/tree/main/hardhat-lottery-backend
GitHub

Error->
PS C:\Users\Asus\Desktop\Lottery\hardhat-lottery-backend> npx hardhat test --network sepolia

Raffle Staging Tests
fulfillRandomWords
Setting up test...
Starting TimeStamp: 1726030908
Setting up Listener...
Setting up Listener...
Entering Raffle...
Entrance Fee: 10000000000000000
Account Balance: 143423302790861431
Entered Raffle!
Winner Start Balance: 143423302790861431
Found the winner
Recent Winner: 0x19e46f1c9fc18586c78eAf66244Cf4fa8bE65A86
Number of Players: 0
Last TimeStamp: 1726031328
Lottery State: 0
Winner End Balance: 142020843522627218
AssertionError: expected '142020843522627218' to equal '153423302790861431'
at Proxy. (C:\Users\Asus\Desktop\Lottery\hardhat-lottery-backend\test\staging\Lottery.staging.test.js:57:32)
at processTicksAndRejections (node:internal/process/task_queues:95:5) {
showDiff: true,
actual: '142020843522627218',
expected: '153423302790861431',
operator: 'strictEqual'
}
1) works with live Chainlink Keepers and Chainlink VRF, we get a random winner

0 passing (2m)
1 failing

1. Raffle Staging Tests
   fulfillRandomWords
   works with live Chainlink Keepers and Chainlink VRF, we get a random winner:

   AssertionError: expected '142020843522627218' to equal '153423302790861431'

   • expected - actual

   -142020843522627218
   +153423302790861431
   

[HarigovindM-G]

@M-D-Nadeem I remembered to have face similar issue like this while assertion , but then i used

assert.equal(
                  winner_endBal.toString(),
                  winnerStartingBalance.add(LotteryFee).toString()
                )

instead of

assert.equal(winnerEndBal.toString(), (winnerStartBal+entrenceFee).toString());

because when it comes to BigNumber addition i guess we should use the .add() operator , could you try that and tell me if it works

[M-D-Nadeem]

I do noticed that but in new update it has been changed .add() function did not exist, now it supports + operator

But the problem is not with this statement
assert.equal(winnerEndBal.toString(), (winnerStartBal+entrenceFee).toString());
If you notice the output that i am getting in my terminal, there you will find that the winnerEndBal is not reducing, means the money is not getting transferred.
Please have a look on my output

Here, Winner Start Balance: 89909196208393510 and Winner End Balance: 89515952754643545, this is the problem end balance is reducing

[M-D-Nadeem]

@HarigovindM-G
I got to know where i was getting wrong
I was calling the starting balance without waiting for the enterRaffle() function to finish . So I said we wait for 1 confirmation before getting the winnerStartingBalance.

`
try {
console.log("Entering Raffle...");
console.log("Entrance Fee: ", entrenceFee.toString());
const tx = await lottery.enterLottery({ value: entrenceFee });
await tx.wait(1);
console.log("Entered Raffle!");
winnerStartBal = await ethers.provider.getBalance(accounts[0].address); //Changed this line, earlier i was calling this //before entering the lottery
console.log("Winner Start Balance: ", winnerStartBal.toString());

            }

`

Thanks a lot @HarigovindM-G , i really appreciate your efforts and time you put in to solve my problem.

[nabeel-ahmed004]

Hey @HarigovindM-G. Sorry for disturbing again and again but I have no other choice. I looked at your repo and re adjusted my code. Before modifying my code, I was also using VRF V2.5 and my code was also working completely as well as my unit tests were perfect but only my staging test was failing. After modifying my code, only my staging test is failing. So if and whenever you are free, could you please look into my repo: https://github.com/nabeel-ahmed004/smartcontract-lottery. I would be very thankful to you. <3<3

I had faced issue implementing this validation , you can see in my code that , i have commented out this validation , because aldready , performUpkeep will only be performed when checkupkeep is true , so it is basically double validation . so we can comment it out

if(!upkeepNeeded){
            revert Lottery__UpkeepNotNeeded(address(this).balance, s_players.length, uint256(s_lotteryState));
        }

I have also tried doing this but if I comment these lines out, then my unit tests fail and my staging test does not work as well.