-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] export replay as MP4 #9823
Comments
is this feature worth working on? i mean will it get accepted by the PS devs if i create a system that exports replay in html format to mp4? @KrisXV |
I would personally advise you to use OBS or some other screen recorder in case this feature request doesn't pan out. |
I somehow managed to convert the HTML replay to a decent (could be better) quality video (without sound). Your thoughts on this @DaWoblefet ? |
I won't definitively say no, but I can't think of there being much value in exporting replays as video files. Playback on replays is pretty intuitive, and you can already download replays. Sharing replays is as easy as sharing the URL. I would think managing a video file would be more difficult than just passing around a URL (e.g. Discord and Twitter disallow uploading large files, which longer replays will easily reach). If such a feature existed it would also likely need to be rate limited somehow, or processed entirely client-side so malicious actors couldn't just spin up a bunch of video request on 1000-turn replays. For all those reasons, I would not recommend proceeding with it. |
I understand, but 1000 turns replays are rare and we can definitely put a size limit for the video (like 25-30MB). The size of replay video will not be that large, for example a 20 secs video was of size 600KB and it takes around 4-7 secs to complete one turn in a battle replay. So by considering the worst case scenario (that is each turn taking exactly 7secs to complete) and doing the rough calculation, the size of a 100 turns replay will be 21MB and duration will be 12mimutes 28 seconds. And im sure most users, at some point, wished there was a feature to export the battle replay as video so that they can share it with their friends. OR |
I would be interested in merging such a feature, but:
|
ah no, We don't have to interact with a browser for all these processes to take place. My idea is to implement it directly into the server here is an example output video.
video.mp4 |
Hm. That sounds like it's best fit for a third party downloader website, like one of those YouTube downloader sites. I'd be willing to link to it from replay pages, but I definitely wouldn't want to host it on our own infra; it's a bit of a maintenance nightmare. |
Yes, I understand. Also, I've been doing some research lately and I think I can make this feature client side totally. |
i think it would work best as a browser extension honestly. ill look into it |
I have a working project in my profile of the same. Feel free to look into it if that can be of any help on how to go about it 🙇 |
it would be much easier to share replays on the internet if there were an export replay as MP4 so I could download the video and post it wherever I see fit.
The text was updated successfully, but these errors were encountered: