Skip to content

Commit b66e9ff

Browse files
authored
fix: disabled prop for voting date inputs (#4342)
* fix: disabled prop for voting date inputs * Refactor date input components to use is-editing prop * format fix
1 parent 1226598 commit b66e9ff

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

src/components/SpaceCreateVoting.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,14 +192,14 @@ defineEmits<{
192192
<SpaceCreateVotingDateStart
193193
:delay="space.voting?.delay"
194194
:date="dateStart"
195-
:disabled="isEditing"
195+
:is-editing="isEditing"
196196
@select="value => setDateStart(value)"
197197
/>
198198

199199
<SpaceCreateVotingDateEnd
200200
:period="space.voting?.period"
201201
:date="dateEnd"
202-
:disabled="isEditing"
202+
:is-editing="isEditing"
203203
@select="value => setDateEnd(value)"
204204
/>
205205
</div>

src/components/SpaceCreateVotingDateEnd.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ const { d } = useI18n();
44
const props = withDefaults(
55
defineProps<{
66
period?: number | null;
7+
isEditing?: boolean;
78
date: number;
89
}>(),
910
{
@@ -12,6 +13,7 @@ const props = withDefaults(
1213
);
1314
1415
const dateString = computed(() => d(props.date * 1e3, 'short', 'en-US'));
16+
const isDisabled = computed(() => !!props.period || props.isEditing);
1517
1618
const emit = defineEmits(['select']);
1719
</script>
@@ -20,10 +22,10 @@ const emit = defineEmits(['select']);
2022
<InputDate
2123
type="end"
2224
:title="$t(`create.end`)"
23-
:disabled="!!period"
25+
:disabled="isDisabled"
2426
:date="date"
2527
:date-string="dateString"
26-
:tooltip="!!period ? $t('create.periodEnforced') : null"
28+
:tooltip="!!period && !isEditing ? $t('create.periodEnforced') : null"
2729
@update:date="emit('select', $event)"
2830
/>
2931
</template>

src/components/SpaceCreateVotingDateStart.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ const { t, d } = useI18n();
44
const props = withDefaults(
55
defineProps<{
66
delay?: number | null;
7+
isEditing?: boolean;
78
date: number;
89
}>(),
910
{
@@ -17,6 +18,7 @@ const dateString = computed(() =>
1718
? t('create.now')
1819
: d(props.date * 1e3, 'short', 'en-US')
1920
);
21+
const isDisabled = computed(() => !!props.delay || props.isEditing);
2022
2123
const emit = defineEmits(['select']);
2224
</script>
@@ -25,10 +27,10 @@ const emit = defineEmits(['select']);
2527
<InputDate
2628
type="start"
2729
:title="$t(`create.start`)"
28-
:disabled="!!delay"
30+
:disabled="isDisabled"
2931
:date="date"
3032
:date-string="dateString"
31-
:tooltip="!!delay ? $t('create.delayEnforced') : null"
33+
:tooltip="!!delay && !isEditing ? $t('create.delayEnforced') : null"
3234
@update:date="emit('select', $event)"
3335
/>
3436
</template>

0 commit comments

Comments
 (0)