Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPS-45767] Let an external browser callback be provided to use, supports Snowflake VS Code Extension SSO #1003

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

sfc-gh-klin
Copy link
Contributor

We've been patching this for 1.5 years on our end. Without it, there are SSO problems when customers login, since the VS Code API has an API to openExternal: https://code.visualstudio.com/api/references/vscode-api (search for openExternal) that controls how browser windows open from extensions.

Can we have this officially inside the node connector?

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-klin sfc-gh-klin requested a review from a team as a code owner February 5, 2025 20:03
@sfc-gh-klin sfc-gh-klin changed the title [APPS-45767] Let an external browser callback be provided to use, supports Snowflake VS Code Extension officially [APPS-45767] Let an external browser callback be provided to use, supports Snowflake VS Code Extension SSO Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Kelly Huntlin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sfc-gh-klin
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-klin
Copy link
Contributor Author

recheck

lib/authentication/authentication.js Outdated Show resolved Hide resolved
lib/authentication/authentication.js Outdated Show resolved Hide resolved
@sfc-gh-klin
Copy link
Contributor Author

Thank you for the approvals! This will really ease our snowflake-sdk upgrade process.

@sfc-gh-klin sfc-gh-klin merged commit 09433c0 into master Feb 7, 2025
40 of 45 checks passed
@sfc-gh-klin sfc-gh-klin deleted the klin-externalBrowserCb branch February 7, 2025 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants