-
Notifications
You must be signed in to change notification settings - Fork 139
SNOW-2111092 TypeScript Support #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1080 +/- ##
==========================================
+ Coverage 89.21% 89.38% +0.16%
==========================================
Files 76 76
Lines 7558 7553 -5
Branches 0 51 +51
==========================================
+ Hits 6743 6751 +8
+ Misses 815 795 -20
- Partials 0 7 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR implements TypeScript support, allowing us to write new code in TypeScript and start the migration of old files.
/dist
folder will contain compiled JS code. Customers will start using/dist/index.js
as an entry point.New devDependencies
@types/**
- these are*.d.ts
files for libraries we usets-node
- used by mocha to run tests with typescript build pipelineEnsuring that compiled code works as expected
npm pack
would fail and would prevent us from publishing a broken buildSecurity Review
https://github.com/snowflakedb/security_reviews/pull/6846
Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code)npm run test:unit
andnpm run test:integration
)