Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1356385 add tests for node 22 to matrix #935

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

sfc-gh-akolodziejczyk
Copy link
Contributor

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk commented Oct 11, 2024

Description

SNOW-1356385 Added node 22 to test matrix

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (4f20086) to head (87c6033).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #935   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files          66       66           
  Lines        6455     6455           
=======================================
  Hits         5740     5740           
  Misses        715      715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk marked this pull request as ready for review October 14, 2024 12:33
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk requested a review from a team as a code owner October 14, 2024 12:33
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk enabled auto-merge (squash) October 14, 2024 12:34
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk merged commit c748d3b into master Oct 14, 2024
59 checks passed
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk deleted the SNOW-1356385 branch October 14, 2024 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants