SNOW-834366 Fall back to use current schema for temp objects in write… #1617
Conversation
…_pandas Description In 3.0.0 we made a change to use target schema for temp stage and file format, but this breaks user when they only have stage/file format creation privilege in current schema, but not the target schema. This change adds a fallback mechanism to use current schema if creating temp object fails on target schema. Testing integ test
sfc-gh-sfan
requested review from
a team,
sfc-gh-aling,
sfc-gh-hpu,
sfc-gh-jdu and
sfc-gh-stan
and removed request for
a team
| _do_create_temp_stage( | ||
| cursor, stage_location, compression, auto_create_table, overwrite | ||
| ) |
There was a problem hiding this comment.
why are we creating temp stage again if we encountered an exception?
There was a problem hiding this comment.
ohh, I see. This will use current_schema instead of temp schema
|
Would this change also need to go in sproc-connector as the issue which caused this came from stored procs? |
Yes. I'm working on the sp connector changes :) |
Codecov Report
@@ Coverage Diff @@
## main #1617 +/- ##
==========================================
+ Coverage 82.66% 82.71% +0.05%
==========================================
Files 64 64
Lines 8992 9013 +21
Branches 1331 1331
==========================================
+ Hits 7433 7455 +22
+ Misses 1220 1219 -1
Partials 339 339
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…_pandas
Description
In 3.0.0 we made a change to use target schema for temp stage and file format, but this breaks user when they only have stage/file format creation privilege in current schema, but not the target schema.
This change adds a fallback mechanism to use current schema if creating temp object fails on target schema.
Testing
integ test
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-834366
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.