Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLA document link #1622

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Update CLA document link #1622

merged 2 commits into from
Jul 20, 2023

Conversation

sfc-gh-stan
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    CLA document is moved to a new repo, we need to update the link. This should be automated in the future.

@sfc-gh-stan sfc-gh-stan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #1622 (6de32b8) into main (faa906b) will increase coverage by 1.30%.
The diff coverage is 95.22%.

@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
+ Coverage   81.50%   82.80%   +1.30%     
==========================================
  Files          61       64       +3     
  Lines        8558     9015     +457     
  Branches     1263     1331      +68     
==========================================
+ Hits         6975     7465     +490     
+ Misses       1256     1213      -43     
- Partials      327      337      +10
Impacted Files Coverage Δ
src/snowflake/connector/__init__.py 100.00% <ø> (ø)
src/snowflake/connector/_sql_util.py 95.83% <ø> (ø)
src/snowflake/connector/auth/default.py 94.73% <ø> (ø)
src/snowflake/connector/auth/oauth.py 80.95% <ø> (ø)
src/snowflake/connector/auth/okta.py 83.15% <ø> (ø)
src/snowflake/connector/auth/usrpwdmfa.py 72.72% <ø> (ø)
src/snowflake/connector/azure_storage_client.py 90.90% <ø> (-0.76%) ⬇️
src/snowflake/connector/connection_diagnostic.py 10.19% <ø> (+0.02%) ⬆️
src/snowflake/connector/description.py 100.00% <ø> (ø)
src/snowflake/connector/errorcode.py 100.00% <ø> (ø)
... and 54 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sfc-gh-mkeller
sfc-gh-mkeller approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-stan sfc-gh-stan merged commit 85df67c into main Jul 20, 2023
@sfc-gh-stan sfc-gh-stan deleted the Update-CLA-document-link branch July 20, 2023 22:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-stan @sfc-gh-mkeller @sfc-gh-aling