Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-874975: Migrate out of sfc-dev1 #1666

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

sfc-gh-aalam
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-874975

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Move to new sfc-dev2 buckets.

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1666 (bd38cbc) into main (85df67c) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head bd38cbc differs from pull request most recent head b755d14. Consider uploading reports for the commit b755d14 to get more accurate results

@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
- Coverage   83.45%   83.39%   -0.07%     
==========================================
  Files          64       64              
  Lines        9256     9256              
  Branches     1350     1350              
==========================================
- Hits         7725     7719       -6     
- Misses       1195     1201       +6     
  Partials      336      336              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review July 27, 2023 20:10
@sfc-gh-aalam sfc-gh-aalam requested review from a team, sfc-gh-stan, sfc-gh-vnayak, sfc-gh-mkeller and sfc-gh-aling and removed request for a team July 27, 2023 20:11
@sfc-gh-aalam sfc-gh-aalam merged commit 43b3e32 into main Jul 31, 2023
72 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-874975-migrate-from-sfc-dev1-data branch July 31, 2023 18:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants