Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1613751: snowflake-export-cert tool is broken #2015

Closed
Baguage opened this issue Aug 6, 2024 · 3 comments
Closed

SNOW-1613751: snowflake-export-cert tool is broken #2015

Baguage opened this issue Aug 6, 2024 · 3 comments
Assignees
Labels
bug status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@Baguage
Copy link

Baguage commented Aug 6, 2024

Python version

Python 3.12.4

Operating system and processor architecture

Linux-5.4.0-153-generic-x86_64-with-glibc2.38

Installed packages

asn1crypto==1.5.1
certifi==2024.7.4
cffi==1.16.0
charset-normalizer==3.3.2
cryptography==42.0.8
filelock==3.15.4
idna==3.7
packaging==24.1
platformdirs==4.2.2
pycparser==2.22
PyJWT==2.9.0
pyOpenSSL==24.2.1
pytz==2024.1
requests==2.32.3
snowflake-connector-python==3.12.0
sortedcontainers==2.4.0
tomlkit==0.13.0
typing_extensions==4.12.2
urllib3==2.2.2

What did you do?

snowflake-connector-python comes with `snowflake-export-certs` tool, but it appears to be broken:


(venv) root@barbarian:~/venv# bin/snowflake-export-certs
Traceback (most recent call last):
  File "/root/venv/bin/snowflake-export-certs", line 5, in <module>
    from snowflake.connector.tool.export_certs import main
ModuleNotFoundError: No module named 'snowflake.connector.tool.export_certs'

I believe it can be fixed by removing https://github.com/snowflakedb/snowflake-connector-python/blob/main/setup.cfg#L79 (snowflake-export-certs = snowflake.connector.tool.export_certs:main) - there is no snowflake.connector.tool.export_certs module as far as I can tell.



### What did you expect to see?

No error or no `snowflake-export-certs` command in the package

### Can you set logging to DEBUG and collect the logs?

```bash
import logging
import os

for logger_name in ('snowflake.connector',):
    logger = logging.getLogger(logger_name)
    logger.setLevel(logging.DEBUG)
    ch = logging.StreamHandler()
    ch.setLevel(logging.DEBUG)
    ch.setFormatter(logging.Formatter('%(asctime)s - %(threadName)s %(filename)s:%(lineno)d - %(funcName)s() - %(levelname)s - %(message)s'))
    logger.addHandler(ch)
@github-actions github-actions bot changed the title https://github.com/snowflakedb/snowflake-connector-python/issues SNOW-1613751: https://github.com/snowflakedb/snowflake-connector-python/issues Aug 6, 2024
@Baguage Baguage changed the title SNOW-1613751: https://github.com/snowflakedb/snowflake-connector-python/issues SNOW-1613751: snowflake-export-cert tool is broken Aug 11, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Aug 13, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage Issue is under initial triage and removed needs triage labels Aug 13, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team and removed status-triage Issue is under initial triage labels Aug 13, 2024
@sfc-gh-dszmolka
Copy link
Contributor

hi - thank you for pointing this out. Removing reference in #2023 because module itself has been removed/consolidated 6 years ago.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Aug 13, 2024
@sfc-gh-dszmolka
Copy link
Contributor

PR merged and will be part of the next release

@sfc-gh-aling
Copy link
Collaborator

we have released the connector v3.12.1 today with the fix, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

No branches or pull requests

3 participants