Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mac regression ci #2051

Merged
merged 14 commits into from
Sep 13, 2024
Merged

Conversation

sfc-gh-aling
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling commented Sep 10, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

pandas-dev/pandas#58809
apache/arrow#41696
https://github.com/apache/arrow/pull/43137/files

we should use ideally the latest mac version

python 3.8 is going to be deprecated soon, switching to 3.10 to align with linux test script

  1. (Optional) PR for stored-proc connector:

@sfc-gh-aling sfc-gh-aling added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Sep 11, 2024
@sfc-gh-aling sfc-gh-aling changed the title fix ci fix mac regression ci Sep 11, 2024
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review September 11, 2024 16:41
@sfc-gh-aalam
Copy link
Collaborator

I see this change is trying to run tests in a 3.10 python version. Are we doing this because of coming 3.8 deprecation? it is not clear from the link provided in the description

@sfc-gh-aling
Copy link
Collaborator Author

sfc-gh-aling commented Sep 13, 2024

@sfc-gh-aalam yeah Python 3.8 is going to be deprecated soon, also I found the linux test script is using python 3.10 so trying to align them.

tox will create new venv of different Python versions to run so I don't think the system python matters too much here as long as it's not deprecated. but ideally we can adopt the latest python for testing which will last longer -- e.g. if we use python 3.10 we need to update the test script 2 year later. but if it's 3.12, we can use the same script for 4 years

let me try if 3.12 is available on our mac test nodes. if it's available we can use 3.12

@sfc-gh-aling
Copy link
Collaborator Author

I have logged another JIRA to update our tests to use python 3.12 in other tests if possible https://snowflakecomputing.atlassian.net/browse/SNOW-1664019

@sfc-gh-aling sfc-gh-aling merged commit 3c82559 into main Sep 13, 2024
94 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1659123-fix-mac-regression-test-ci branch September 13, 2024 22:24
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants