[SNOW-1669128]: Ensure SnowflakeConnection atexit function is registered on import #2061
+28
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-1669128
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Previously, the close_at_exit function for the SnowflakeConnection object
was registered with the
atexit
module during initialization of a SnowflakeConnection object.This caused the Snowpark Session object's atexit function to be registered before the
SnowflakeConnection's object when the Session was made without an existing SnowflakeConnection
object, because the SnowflakeConnection object's atexit was only registered after it was initialized
whereas the Snowpark Session object's atexit was registered when the file was imported. During the
atexit for the Snowpark Session, it attempts to send telemetry regarding cleanup operations, but since
it's connection is already closed, it fails to send the telemetry. Moving the registration of the atexit
function here means that it will happen when the SnowflakeConnection object is imported - and so the
Snowpark Session's atexit function will be registered after, and the order will be correct.