Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1572304: asyncio add proxy support and test #2066

Merged
merged 13 commits into from
Oct 17, 2024

Conversation

sfc-gh-aling
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-aling sfc-gh-aling changed the title add proxy support and test SNOW-1572304: asyncio add proxy support and test Oct 8, 2024
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review October 15, 2024 18:16
@sfc-gh-aling
Copy link
Collaborator Author

I have manually verified the proxy feature via proxy.py project.
we need to have integ test for proxy both for sync and async, I have created another JIRA for the integ test SNOW-1738617

@sfc-gh-aling sfc-gh-aling merged commit 8534340 into dev/aio-connector Oct 17, 2024
116 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1572304-proxy-support branch October 17, 2024 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants