Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1654536: async binding stage bind upload agent #2069

Conversation

sfc-gh-aling
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-aling sfc-gh-aling changed the title SNOW-1654536: async binding stage bind upload agent new SNOW-1654536: async binding stage bind upload agent Oct 15, 2024
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review October 15, 2024 22:31
@sfc-gh-yuwang
Copy link
Contributor

I found that old tests all execute query in such way: connection.cursor().execute, do you thing change them to cursor.execute without creating new cursors each time will make merge gate faster or will it reduce internet overhead?

@sfc-gh-aling
Copy link
Collaborator Author

@sfc-gh-yuwang this is a good feedback.

I don't think there is much performance gain here because cnx.cursor() is just instantiating a cursor class which contains no IO operation.
but it's a good practice to reuse cursor for code simplicity.

@sfc-gh-aling sfc-gh-aling merged commit ce1b42c into dev/aio-connector Oct 18, 2024
117 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1654536-async-binding-stage-bind-upload-agent-new branch October 18, 2024 18:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants